Skip to content

Conversation

@Ruby-a07
Copy link
Collaborator

@Ruby-a07 Ruby-a07 commented Mar 18, 2025

Description

  1. add support for klingai platform and partial screenshot (to enhance the browser toolkit to take a sub-screenshot for anywhere on a page, and avoid cases when download inavailable)
  2. this feature is also for the new usecase I added

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTION guide (required)
  • I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (no issue raised, this is for a new usecase I added)
  • I have checked if any dependencies need to be added or updated in pyproject.toml and uv lock
  • I have updated the tests accordingly (required for a bug fix or a new feature)
  • I have updated the documentation if needed:
  • I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

@lightaime
Copy link
Member

Thanks for the contribution! We prefer use English as comments. Is that ok for you?

@Ruby-a07
Copy link
Collaborator Author

Ruby-a07 commented Mar 18, 2025 via email

@Wendong-Fan Wendong-Fan requested a review from zechengz March 18, 2025 20:14
@Wendong-Fan Wendong-Fan changed the title Feature: add virtual try-on toolkit (with klingai platform); add partial screenshot ability in browser_toolkit (accompanied with the new community usecase) feat: add virtual try-on toolkit (with klingai platform); add partial screenshot ability in browser_toolkit (accompanied with the new community usecase) Mar 18, 2025
@Wendong-Fan Wendong-Fan added the enhancement New feature or request label Mar 18, 2025
@Wendong-Fan Wendong-Fan added this to the Sprint 25 milestone Mar 18, 2025
"message": error_message
}

def get_tools(self) -> List[FunctionTool]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious will this virtual_try_on be used as function tools as it seems only be included in the prompt? Do we have somewhere indicating this function can be used as function tool?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean like the AVAILABLE_ACTIONS_PROMPT in browser_toolkit.py?. Actually I'm not sure where we can indicate that a tool can be used as a tool. (I just find that if I don't specify that in the prompt, owl will always try to find a "virtual try-on" button on the page, keep scrolling and fail)

@zechengz
Copy link
Member

Also what's the motivation to add the klingai try on functionality?

@Ruby-a07
Copy link
Collaborator Author

  1. have translated into English
  2. the motivation is to support my use case

@Ruby-a07 Ruby-a07 requested a review from zechengz March 21, 2025 06:47
if str(identifier) in elements and len(elements[str(identifier)]["rects"]) > 0:
rect = elements[str(identifier)]["rects"][0]

# 获取整页截图并裁剪
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Ruby-a07 ,it seems that the comments are zh,please translate this to English

@zjrwtx
Copy link
Collaborator

zjrwtx commented Mar 27, 2025

and we need to resolve the conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

5 participants