feat: GraphDBBlock #2017
Open
feat: GraphDBBlock #2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@cafeii will help with code review |
zjrwtx
reviewed
Mar 27, 2025
Collaborator
zjrwtx
left a comment
zjrwtx
left a comment
There was a problem hiding this comment.
thanks @X-TRON404 !left some comments
camel/memories/agent_memories.py
Outdated
| """ | ||
| return self._graph_db_block.retrieve( | ||
| query=self._current_query, | ||
| numberOfNearestNeighbours=self._retrieve_limit, |
Collaborator
There was a problem hiding this comment.
Suggested change
| numberOfNearestNeighbours=self._retrieve_limit, | |
| number_of_nearest_neighbours=self._retrieve_limit, |
zjrwtx
reviewed
Mar 27, 2025
| numberOfNearestNeighbours=self._retrieve_limit, | ||
| ) | ||
|
|
||
| def write_records(self, records: List[MemoryRecord]) -> None: |
Collaborator
There was a problem hiding this comment.
may be we can add batch process
cafeii
reviewed
Mar 28, 2025
cafeii
reviewed
Mar 28, 2025
| """ | ||
| CREATE VECTOR INDEX message_embeddings IF NOT EXISTS | ||
| FOR (m:Message) ON (m.embedding) | ||
| OPTIONS {indexConfig: {`vector.dimensions`: 1536, |
Collaborator
There was a problem hiding this comment.
the dim should vary with different embedding models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GraphDBBlock for agent memory. This is a part of the feature for #1712
Checklist
Go over all the following points, and put an
xin all the boxes that apply.Fixes #issue-numberin the PR description (required)pyproject.tomlanduv lockIf you are unsure about any of these, don't hesitate to ask. We are here to help!