-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: Gemini toolcall #2384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Gemini toolcall #2384
Conversation
Wendong-Fan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @JINO-ROHIT , With more complex tasks I’m seeing errors when we force the “tool‑call first, then structured output” sequence. Sometimes ChatAgent().step makes multiple LLM calls, which breaks that assumption. A cleaner fix might be to move the handling into ChatAgent()._format_response_if_needed instead?
| else: | ||
| return await self._arequest_chat_completion(messages, tools) | ||
| # For tool calls, first get the tool response | ||
| completion = self._arequest_chat_completion(messages, tools) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use await for async function
|
hmm great suggestion, will do |
|
can you also post a sample complex task where it fails, so i can test after my changes, thanks! |
|
|
honestly, ive tried a lot to make this work, but in general gemini tool calling seems awful, i cant really get it to work. any ideas on what we do next? |
No worries at all, Jino. I appreciate the effort you've put into the Gemini tool calling. I understand that it's tricky, and it's more of a 'nice-to-have' right now. Let's park this for the time being, and I'll take another look once I've cleared some higher-priority items from my plate |
Gemini support structured output with tool call.
Links #2364