Skip to content

Conversation

@Wendong-Fan
Copy link
Member

Description

Describe your changes in detail (optional if the linked issue already contains a detailed description of the changes).

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTION guide (required)
  • I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
  • I have checked if any dependencies need to be added or updated in pyproject.toml and uv lock
  • I have updated the tests accordingly (required for a bug fix or a new feature)
  • I have updated the documentation if needed:
  • I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

@Wendong-Fan Wendong-Fan self-assigned this Nov 13, 2025
@github-actions github-actions bot added the Review Required PR need to be reviewed label Nov 13, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 13, 2025

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/snapshot_clean_wd

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Wendong-Fan Wendong-Fan marked this pull request as ready for review November 13, 2025 08:33
Base automatically changed from chore/snapshot_clean to master November 13, 2025 12:11
@Wendong-Fan Wendong-Fan reopened this Nov 26, 2025
Copy link
Collaborator

@nitpicker55555 nitpicker55555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we removed all snapshot ref decorations, including those for the latest snapshot. As a result, the agent is now completely unable to operate. Ideally, we should only clean up the historical snapshots, right?
This is also why it seems we can only make changes inside the chatagent.py, the toolkit is stateless and has no ability to modify historical information.

@Wendong-Fan
Copy link
Member Author

It looks like we removed all snapshot ref decorations, including those for the latest snapshot. As a result, the agent is now completely unable to operate. Ideally, we should only clean up the historical snapshots, right? This is also why it seems we can only make changes inside the chatagent.py, the toolkit is stateless and has no ability to modify historical information.

thanks @nitpicker55555 , this refactor needs more time to implement, i will merge #3832 as a temporary solution

cc @fengju0213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review Required PR need to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants