-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: webhook and schedule triggers #3497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| and self.chat_agent | ||
| ): | ||
| # Use provided prompt or convert event to prompt | ||
| if self.default_prompt: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to judge whether "task_content" is in event.payload under the condition of self.default_prompt? like
if self.default_prompt:
prompt = self.default_prompt
if "task_content" in event.payload:
prompt += f"\n\nTask: {event.payload['task_content']}"
if "message" in event.payload:
prompt += f"\n\nEvent: {event.payload['message']}"
or it‘s unnecessary for some reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh didn't realize yes you are right @LuoPengcheng12138 , making a fix asap !
LuoPengcheng12138
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me!
|
Hi there @LuoPengcheng12138 I have added some small updates:
|
|
@Wendong-Fan @nitpicker55555 @LuoPengcheng12138 |
Description
Trigger System Core Implementation
WebhookTrigger: Complete HTTP webhook server implementation with aiohttp backend
TriggerManager: Central orchestration system for all trigger types
Slack Integration & Authentication
SlackAuth: Production-ready webhook signature verification
Slack Webhook Example: Complete integration demonstration
TODOs & Next Steps
Technical Notes
Checklist
Go over all the following points, and put an
xin all the boxes that apply.Fixes #issue-numberin the PR description (required)pyproject.tomlanduv lockIf you are unsure about any of these, don't hesitate to ask. We are here to help!