-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: fix function param type #3499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I think this issue needs to be fixed in playwright/mcp, where there is type: ["string", "null"]. I looked into it and understand that type can be any type, and null means it’s optional—I don’t think we need to handle it. However, the type can be:
|
fengju0213
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Benjmmi thanks for this pr!everything looks good,we just need to place the test files in the tests folder instead of examples
|
@fengju0213 okok, moved test file to test dir, finished |
fengju0213
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything looks good ,thanks @Benjmmi ! I made some minor changes in your PR.
then we can merge it
waleedalzarooni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@fengju0213 Thank you for the revisions; I have already merge it. |
Description
PR for the issue #2669
Checklist
Go over all the following points, and put an
xin all the boxes that apply.Fixes #issue-numberin the PR description (required)pyproject.tomlanduv lockIf you are unsure about any of these, don't hesitate to ask. We are here to help!