Skip to content

Conversation

@nitpicker55555
Copy link
Collaborator

Description

Describe your changes in detail (optional if the linked issue already contains a detailed description of the changes).

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTION guide (required)
  • I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
  • I have checked if any dependencies need to be added or updated in pyproject.toml and uv lock
  • I have updated the tests accordingly (required for a bug fix or a new feature)
  • I have updated the documentation if needed:
  • I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 6, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/browser_get_som_screenshot

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the Review Required PR need to be reviewed label Dec 6, 2025
@nitpicker55555 nitpicker55555 self-assigned this Dec 7, 2025
@fengju0213 fengju0213 added this to the Sprint 44 milestone Dec 8, 2025
@nitpicker55555 nitpicker55555 marked this pull request as draft December 9, 2025 17:51
@nitpicker55555 nitpicker55555 removed the Review Required PR need to be reviewed label Dec 9, 2025
Copy link
Collaborator

@YunfeiZHAO YunfeiZHAO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

)

# NEW: Handle ToolResult with images - inject visual content
from camel.utils.tool_result import ToolResult
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the ToolResult is necessary in _record_tool_calling for type checking, is it better to import it at the beginning of the script or here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think its better to import it at the beginning of the script

@nitpicker55555
Copy link
Collaborator Author

#3495

@nitpicker55555 nitpicker55555 marked this pull request as ready for review December 15, 2025 22:46
@fengju0213 fengju0213 changed the title fix: browser read image in context chore: browser read image in context Dec 17, 2025
@fengju0213
Copy link
Collaborator

minor update in this pr :#3579

if pil_images:
# Create a user message with the image(s)
visual_msg = BaseMessage.make_user_message(
role_name="System",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better be Tool?

)

# NEW: Handle ToolResult with images - inject visual content
from camel.utils.tool_result import ToolResult
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think its better to import it at the beginning of the script

@fengju0213 fengju0213 merged commit bce7af2 into master Dec 18, 2025
14 checks passed
@fengju0213 fengju0213 deleted the fix/browser_get_som_screenshot branch December 18, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Let search agent can directly see images returned by browser_get_som_screenshot

5 participants