-
Notifications
You must be signed in to change notification settings - Fork 1.7k
chore: browser read image in context #3535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
YunfeiZHAO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
camel/agents/chat_agent.py
Outdated
| ) | ||
|
|
||
| # NEW: Handle ToolResult with images - inject visual content | ||
| from camel.utils.tool_result import ToolResult |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the ToolResult is necessary in _record_tool_calling for type checking, is it better to import it at the beginning of the script or here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think its better to import it at the beginning of the script
|
minor update in this pr :#3579 |
camel/agents/chat_agent.py
Outdated
| if pil_images: | ||
| # Create a user message with the image(s) | ||
| visual_msg = BaseMessage.make_user_message( | ||
| role_name="System", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better be Tool?
camel/agents/chat_agent.py
Outdated
| ) | ||
|
|
||
| # NEW: Handle ToolResult with images - inject visual content | ||
| from camel.utils.tool_result import ToolResult |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think its better to import it at the beginning of the script
Description
Describe your changes in detail (optional if the linked issue already contains a detailed description of the changes).
Checklist
Go over all the following points, and put an
xin all the boxes that apply.Fixes #issue-numberin the PR description (required)pyproject.tomlanduv lockIf you are unsure about any of these, don't hesitate to ask. We are here to help!