-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat : Adds Microsoft Outlook Calendar Toolkit #3553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @waleedalzarooni On side note |
waleedalzarooni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outstanding contribution @Tanuj-Taneja1!
Very little for me to say, I will be adding an example file soon but from my testing it seems as though everything works. I'll have a quick think about how to organise the auth and utils files with the mail toolkit and get back to you.
camel/toolkits/microsoft_outlook_toolkits/microsoft_outlook_calendar_toolkit.py
Outdated
Show resolved
Hide resolved
camel/toolkits/microsoft_outlook_toolkits/microsoft_outlook_calendar_toolkit.py
Outdated
Show resolved
Hide resolved
|
Hey @Tanuj-Taneja1, With regards to the order of merging PR's I will focus on getting this PR merged, then could I ask that you refactor the mail toolkit and move it to the new Microsoft toolkits folder as it is currently a standalone toolkit, thanks again! |
waleedalzarooni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@JINO-ROHIT @fengju0213, before reviewing this could you review the calendar toolkit, the plan is to merge the calendar toolkit first, refactor this toolkit then merge - #3553 (review) |
Cool, Seems like a good idea to me |
|
Hi @fengju0213 @JINO-ROHIT if you face any issues or have any questions while reviewing the pr feel free to message me here. You can also ping me on discord at tanuj_taneja |
hi @Tanuj-Taneja1 thank you very much for your contribution!I noticed that you separated the OAuth flow. This is a great design—it allows us to reuse the flow! Since your other PR has already been approved by three maintainer, I will merge that PR first and then continue reviewing this one. |
Description
Fixes #3201
Checklist
Go over all the following points, and put an
xin all the boxes that apply.Fixes #issue-numberin the PR description (required)pyproject.tomlanduv lockIf you are unsure about any of these, don't hesitate to ask. We are here to help!