Skip to content

Conversation

@Tanuj-Taneja1
Copy link
Collaborator

Description

Fixes #3201

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTION guide (required)
  • I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
  • I have checked if any dependencies need to be added or updated in pyproject.toml and uv lock
  • I have updated the tests accordingly (required for a bug fix or a new feature)
  • I have updated the documentation if needed:
  • I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

@Tanuj-Taneja1 Tanuj-Taneja1 added this to the Sprint 44 milestone Dec 9, 2025
@Tanuj-Taneja1 Tanuj-Taneja1 self-assigned this Dec 9, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 9, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/outlook-calender-toolkit

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Tanuj-Taneja1 Tanuj-Taneja1 marked this pull request as ready for review December 9, 2025 13:01
@Tanuj-Taneja1
Copy link
Collaborator Author

Tanuj-Taneja1 commented Dec 9, 2025

Hi @waleedalzarooni
To summarise this pr :
I separated the auth and toolkit logic since it can be reused for other toolkits.
I will refractor the mail toolkit after it and this pr gets merged (just have to remove the auth logic from it)

On side note
can you look into the mypy issue and let me know if you get the error, I am actually not getting the same error on my system (used a vm to run mypy tests since they take too long on my local machine, so it could be a setup issue).
just run : mypy camel/camel/toolkits/microsoft_outlook_toolkits/_auth_utils.py

Copy link
Collaborator

@waleedalzarooni waleedalzarooni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding contribution @Tanuj-Taneja1!

Very little for me to say, I will be adding an example file soon but from my testing it seems as though everything works. I'll have a quick think about how to organise the auth and utils files with the mail toolkit and get back to you.

@waleedalzarooni
Copy link
Collaborator

Hey @Tanuj-Taneja1,

With regards to the order of merging PR's I will focus on getting this PR merged, then could I ask that you refactor the mail toolkit and move it to the new Microsoft toolkits folder as it is currently a standalone toolkit, thanks again!

Copy link
Collaborator

@waleedalzarooni waleedalzarooni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@waleedalzarooni
Copy link
Collaborator

@JINO-ROHIT @fengju0213, before reviewing this could you review the calendar toolkit, the plan is to merge the calendar toolkit first, refactor this toolkit then merge - #3553 (review)

@Tanuj-Taneja1
Copy link
Collaborator Author

Hey @Tanuj-Taneja1,

With regards to the order of merging PR's I will focus on getting this PR merged, then could I ask that you refactor the mail toolkit and move it to the new Microsoft toolkits folder as it is currently a standalone toolkit, thanks again!

Cool, Seems like a good idea to me

@Tanuj-Taneja1
Copy link
Collaborator Author

Hi @fengju0213 @JINO-ROHIT if you face any issues or have any questions while reviewing the pr feel free to message me here. You can also ping me on discord at tanuj_taneja

@fengju0213
Copy link
Collaborator

Hi @fengju0213 @JINO-ROHIT if you face any issues or have any questions while reviewing the pr feel free to message me here. You can also ping me on discord at tanuj_taneja

hi @Tanuj-Taneja1 thank you very much for your contribution!I noticed that you separated the OAuth flow. This is a great design—it allows us to reuse the flow! Since your other PR has already been approved by three maintainer, I will merge that PR first and then continue reviewing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Integrate Microsoft Outlook (Actions & Triggers)

4 participants