Skip to content

Conversation

@coolbeevip
Copy link
Collaborator

Description

Fixes #3661

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTION guide (required)
  • I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
  • I have checked if any dependencies need to be added or updated in pyproject.toml and uv lock
  • I have updated the tests accordingly (required for a bug fix or a new feature)
  • I have updated the documentation if needed:
  • I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 7, 2026

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the Review Required PR need to be reviewed label Jan 7, 2026
@fengju0213 fengju0213 added this to the Sprint 46 milestone Jan 7, 2026
@fengju0213 fengju0213 self-requested a review January 7, 2026 13:15
@waleedalzarooni waleedalzarooni self-requested a review January 8, 2026 11:34
@waleedalzarooni waleedalzarooni assigned a7m-1st and unassigned a7m-1st Jan 8, 2026
@a7m-1st
Copy link
Collaborator

a7m-1st commented Jan 9, 2026

Thanks @coolbeevip for the PR and @waleedalzarooni for notifying me.
Just a quick overview it is a useful feature to have.
But last time I recall workforce has a logging mechanism; so I will see if it doesn't overlap and review the PR either today or tmrw 🫴 .

Copy link
Collaborator

@fengju0213 fengju0213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything is fine!except a typo

Copy link
Collaborator

@a7m-1st a7m-1st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, LGTM. I realized the log system has been updated to reflect the latest architecture. So no issues 👍

Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @coolbeevip ! left some minor comment below

@Wendong-Fan Wendong-Fan added Waiting for Update PR has been reviewed, need to be updated based on review comment and removed Review Required PR need to be reviewed labels Jan 12, 2026
@Wendong-Fan
Copy link
Member

thanks @coolbeevip !

@Wendong-Fan Wendong-Fan merged commit e7f5d9f into master Jan 19, 2026
14 checks passed
@Wendong-Fan Wendong-Fan deleted the issue-3661 branch January 19, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting for Update PR has been reviewed, need to be updated based on review comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Add TaskUpdatedEvent for tracking task modifications

4 participants