-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: Add AtlasCloud model integration #3683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add AtlasCloudModel class inheriting from OpenAICompatibleModel - Add AtlasCloudConfig for model configuration - Register AtlasCloud in ModelFactory and ModelPlatformType - Add two basic model types: ATLASCLOUD_GPT_OSS_120B and ATLASCLOUD_GLM_4_7 - Support string model names for all AtlasCloud models (362+ models) - Add is_atlascloud property to unified_model_type - Configure token limits (64,000 tokens) for AtlasCloud models - Add example code and unit tests - Update documentation with AtlasCloud usage guide This integration allows users to access all AtlasCloud models via: - Predefined enum types (ATLASCLOUD_GPT_OSS_120B, ATLASCLOUD_GLM_4_7) - String model names for any AtlasCloud model (e.g., 'minimaxai/minimax-m2.1') API endpoint: https://api.atlascloud.ai/v1 Environment variable: ATLASCLOUD_API_KEY
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
thanks for your contribution!and sorry for late reply |
fengju0213
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work! @YC0101 just submit some minor update to this pr directlt since it's a pr from fork repo
waleedalzarooni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @YC0101,
One quick tweak otherwise looks great!
| MINIMAX_M2 = "MiniMax-M2" | ||
| MINIMAX_M2_STABLE = "MiniMax-M2-Stable" | ||
|
|
||
| # AtlasCloud models |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing method definition
@property def is_atlascloud(self) -> bool: r"""Returns whether this type of models is served by AtlasCloud.""" return self in { ModelType.ATLASCLOUD_GPT_OSS_120B, ModelType.ATLASCLOUD_GLM_4_7, }
without this is_atlascloud returns true for every model
e.g. ModelType.GPT_40.is_atlascloud would return True when it is False
Wendong-Fan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @YC0101 , @fengju0213 @waleedalzarooni , i will do enhance in another pr
Fixes #3682
Description
This integration allows users to access all AtlasCloud models via:
API endpoint: https://api.atlascloud.ai/v1
Environment variable: ATLASCLOUD_API_KEY
Checklist
Go over all the following points, and put an
xin all the boxes that apply.Fixes #issue-numberin the PR description (required)pyproject.tomlanduv lockIf you are unsure about any of these, don't hesitate to ask. We are here to help!