Skip to content

Conversation

@fengju0213
Copy link
Collaborator

@fengju0213 fengju0213 commented Jan 15, 2026

Description

Root cause:
Quality-check recovery cleaned up task tracking (including _assignees) before
retrying. The retry path posted the task again but did not restore the _assignees
mapping, so subsequent quality checks could not find the assignee and logged “No
assignee found in _assignees”.

Fix:
Update _post_task to always set self._assignees[task.id] = assignee_id whenever a
task is posted. This guarantees assignee mapping is restored on retries (and any
other reposts), preventing failures in the quality-check recovery flow.

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTION guide (required)
  • I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
  • I have checked if any dependencies need to be added or updated in pyproject.toml and uv lock
  • I have updated the tests accordingly (required for a bug fix or a new feature)
  • I have updated the documentation if needed:
  • I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 15, 2026

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Wendong-Fan Wendong-Fan merged commit 66fab59 into master Jan 15, 2026
15 checks passed
@Wendong-Fan Wendong-Fan deleted the fix-asign-lost branch January 15, 2026 21:25
Copy link
Collaborator

@a7m-1st a7m-1st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had the chance to look at the edge cases, but ya i get whats happening, the task is perhaps added to the failed queue and thus the dictionary remained clear of the task. Thus retry can't find it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review Required PR need to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants