Skip to content

Conversation

@JINO-ROHIT
Copy link
Collaborator

this pr skips installation if the env already exists.

  1. we can check how much of a speedup this is.
  2. should we handle the cleanup of venv in the camel base implementation rather than eigent?

ref #3701

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 17, 2026

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the Review Required PR need to be reviewed label Jan 17, 2026
@JINO-ROHIT JINO-ROHIT self-assigned this Jan 17, 2026
Copy link
Collaborator

@a7m-1st a7m-1st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @JINO-ROHIT, it works as expected. Now env doesn't reinitialize on multi init

@JINO-ROHIT JINO-ROHIT requested a review from fengju0213 January 18, 2026 16:46
@a7m-1st
Copy link
Collaborator

a7m-1st commented Jan 18, 2026

1 we can check how much of a speedup this is.
2 should we handle the cleanup of venv in the camel base implementation rather than eigent?

For (1) it is a speedup of 3.77x (could have been 4, but init takes time anyways) at least.
For (2) I guess for now its not that urgent as its already patched in eigent's TerminalToolkit extension

@fengju0213 fengju0213 added this to the Sprint 48 milestone Jan 19, 2026
@Wendong-Fan Wendong-Fan removed the Review Required PR need to be reviewed label Jan 19, 2026
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @JINO-ROHIT !

@Wendong-Fan Wendong-Fan merged commit a8085d9 into master Jan 19, 2026
13 of 14 checks passed
@Wendong-Fan Wendong-Fan deleted the optim-terminal-toolkit branch January 19, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] terminal toolkit taking too much space + env setup optimization

4 participants