-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: add PptxNodeToolkit with PptxGenJS support #3712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: add PptxNodeToolkit with PptxGenJS support #3712
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aviralgarg05. Great work. Left some minor comments
JINO-ROHIT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @aviralgarg05 can you add/update the example file to show the new changes/differences, would be also nice to add in the comments the pre-reqs for using this toolkit, ie node etc
bytecii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. Thanks!
- Add node engine requirement in package.json - Add scripts README - Implement theme support in JS and Python - Update unit tests
# Conflicts: # camel/toolkits/__init__.py
- Fix unused variable in test - Sort imports in camel/toolkits/__init__.py - Fix line length violations in camel/toolkits/pptx_node_toolkit.py
Resolved merge conflicts, added PyYAML dependency, fixed formatting issues, and verified tests.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
# Conflicts: # camel/retrievers/__init__.py # camel/types/__init__.py
Description
This pull request introduces the PptxNodeToolkit, a new toolkit designed to generate PowerPoint (.pptx) presentations by leveraging the PptxGenJS Node.js library.
While CAMEL already provides a native PPTXToolkit based on
python-pptx, this new toolkit offers a "hybrid" alternative for users who require the specific layout capabilities, template support, or ease of use provided by thePptxGenJSecosystem.Key Changes:
camel/toolkits/scripts/that handles the actual presentation creation, slide formatting (titles, headings, bullets), and table rendering.subprocess, returning status messages to the agent.Note: Users will need
nodeandpptxgenjsinstalled in their environment to utilize this specific toolkit.Checklist
Go over all the following points, and put an
xin all the boxes that apply.Fixes #915in the PR description (required)pyproject.tomlanduv lock(Node.js dependency is external)