feat: Chatagent skills #3732

fengju0213 · 2026-01-21T16:56:56Z

Description

Describe your changes in detail (optional if the linked issue already contains a detailed description of the changes).

Checklist

Go over all the following points, and put an x in all the boxes that apply.

I have read the CONTRIBUTION guide (required)
I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
I have checked if any dependencies need to be added or updated in pyproject.toml and uv lock
I have updated the tests accordingly (required for a bug fix or a new feature)
I have updated the documentation if needed:
I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

…nto chatagent-skill

coderabbitai · 2026-01-21T16:59:06Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🔍 Trigger a full review

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch chatagent-skill

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

lightaime · 2026-01-23T02:18:16Z

Why don’t we implement skills as tools like I mentioned?

fengju0213 · 2026-01-23T06:21:20Z

Why don’t we implement skills as tools like I mentioned?

I've surveyed several repos; some use tools, some don't. I think each approach likely has its advantages, and perhaps we can discuss it and decide which method to adopt.

…nto chatagent-skill

waleedalzarooni

LGTM just one quick comment

waleedalzarooni · 2026-01-29T12:28:19Z

camel/toolkits/skill_toolkit.py

+        )
+
+    def _get_skills(self) -> Dict[str, Dict[str, str]]:
+        self._skills_cache = self._scan_skills()


There is no check whether self._skills_cache is not none, in cases where there are repeated skill related tool calls this could result in unnecessary scans within a given session. Consider adding if self._skills_cache is None: to prevent this.

For now using cache will prevent the case for example agent create new skill on the fly the reuse the skill right? Maybe we should remove it for now. WDYT?

zechengz

Also add some unit tests

camel/toolkits/skill_toolkit.py

zechengz · 2026-01-30T10:07:44Z

camel/toolkits/skill_toolkit.py

+                f"({skill['path']})\n"
+            )
+        lines.append("</available_skills>")
+        if not skills:


Move this below the skills = self._get_skills()

zechengz · 2026-01-30T10:15:37Z

camel/toolkits/skill_toolkit.py

+        skills = self._get_skills()
+        skill = skills.get(name)
+        if not skill:
+            available = ", ".join(sorted(skills.keys())) or "none"


Should this also includes the description of path to each skills?

camel/toolkits/skill_toolkit.py

zechengz · 2026-01-30T10:32:57Z

camel/toolkits/skill_toolkit.py

+            roots.append(("system", codex_home_path / "skills" / ".system"))
+        return roots
+
+    def _find_repo_root(self) -> Path:


IMO the assumption of .git is incorrect here
either we just use working directory or let user specify another directory for the repo / workspace scope skill

zechengz · 2026-01-30T10:49:10Z

camel/toolkits/skill_toolkit.py

+
+        try:
+            contents = path.read_text(encoding="utf-8")
+        except OSError as exc:


Maybe we can do this

define a general skill error class

class SkillError(Exception)

and we can have

SkillFrontmatterMissing

etc inherit SkillError

then at the place we call _parse_skill (just returns dict[str, str])

we have something like

try: skill = _parse_skill(path) except SkillError as e: logger.warning("Skip %s: %s", path, e) continue

it might be over-engineering for this use case as _parse_skill is an internal method only called by _scan_skills, so detailed exception types aren't exposed to external callers

zechengz · 2026-01-30T10:55:23Z

camel/toolkits/skill_toolkit.py

+                info = self._parse_skill(path)
+                if not info:
+                    continue
+                name = info["name"]


Can we make the scope related overwriting more explicit here? and add some comments

zechengz · 2026-01-30T11:01:33Z

examples/toolkits/skill_toolkit.py

Maybe we can have a folder in examples toolkits called skill_toolkit with a demo skill and a python script

camel/toolkits/skill_toolkit.py

zechengz · 2026-01-30T11:05:54Z

camel/toolkits/skill_toolkit.py

+
+import os
+from pathlib import Path
+from typing import Dict, List, Optional, Tuple


Let's use dict, list, tuple and

dict[str, str] | None

instead of import from typing

https://peps.python.org/pep-0585/

i think it's good for now, as camel repo uses typing a lot, let's unify the code style with typing

Wendong-Fan

1

Wendong-Fan

Nice implementation! Found a couple small issues noted inline. Also +1 to adding unit tests as @zechengz mentioned.

Wendong-Fan · 2026-02-04T18:22:42Z

camel/toolkits/skill_toolkit.py

+        )
+
+    def _get_skills(self) -> Dict[str, Dict[str, str]]:
+        self._skills_cache = self._scan_skills()


This overwrites the cache on every call, so it never actually uses the cached data. Should check if cache exists first:

if self._skills_cache is None: self._skills_cache = self._scan_skills() return self._skills_cache

Wendong-Fan · 2026-02-04T18:22:42Z

camel/toolkits/skill_toolkit.py

+            "- Safety and fallback: If a skill can't be applied cleanly "
+            "(missing files, unclear instructions), state the issue, pick the "
+            "next-best approach, and continue.\n"
+            "\n" + " ".join(lines)


Using space join here makes the output hard to read since all the XML content ends up on one line. Consider using "\n".join() instead for better readability.

Wendong-Fan

added enhance pr #3778 to resolve comments by @zechengz , also did other enhancement and fix as mentioned in the pr description, feel free to check

fengju0213 added 8 commits January 13, 2026 23:12

update

f8d4d5e

Merge branch 'master' of https://github.com/camel-ai/camel

0ffcbf8

Merge branch 'master' of https://github.com/camel-ai/camel

02ff107

Merge branch 'master' of https://github.com/camel-ai/camel

2b80e64

update

23da7a8

update

359e9a9

Merge branch 'chatagent-skill' of https://github.com/camel-ai/camel i…

b47860c

…nto chatagent-skill

Update workforce.py

7dff094

github-actions bot added the Review Required PR need to be reviewed label Jan 21, 2026

fengju0213 added 2 commits January 22, 2026 00:58

Update pyproject.toml

2e70e14

Update uv.lock

03b2801

revert workforce files to master

6718cd9

fengju0213 changed the title ~~feat: Chatagent skill~~ feat: Chatagent skills Jan 21, 2026

fengju0213 self-assigned this Jan 21, 2026

fengju0213 marked this pull request as draft January 21, 2026 17:05

fengju0213 and others added 2 commits January 22, 2026 09:41

Update list_skills.py

b762a92

Merge branch 'master' into chatagent-skill

2c92651

fengju0213 linked an issue Jan 22, 2026 that may be closed by this pull request

[Feature Request] Chatagent support Skill #3711

Closed

2 tasks

Wendong-Fan requested a review from zechengz January 23, 2026 01:08

fengju0213 added 2 commits January 26, 2026 18:18

update to toolkit

0ad0bfb

Update skill_toolkit.py

947948a

fengju0213 marked this pull request as ready for review January 26, 2026 10:29

fengju0213 and others added 3 commits January 26, 2026 18:29

Merge branch 'master' into chatagent-skill

9ec014d

Update skill_toolkit.py

70bc912

Merge branch 'chatagent-skill' of https://github.com/camel-ai/camel i…

26439f5

…nto chatagent-skill

fengju0213 added this to the Sprint 47 milestone Jan 26, 2026

update

717e00c

fengju0213 added 3 commits January 27, 2026 13:09

Update chat_agent.py

fbc248f

Merge branch 'master' into chatagent-skill

5115977

Update chat_agent.py

f85a79f

waleedalzarooni self-requested a review January 27, 2026 13:38

Update skill_toolkit.py

96782a8

waleedalzarooni reviewed Jan 29, 2026

View reviewed changes

zechengz reviewed Jan 30, 2026

View reviewed changes

fengju0213 modified the milestones: Sprint 47, Sprint 48 Feb 1, 2026

Wendong-Fan reviewed Feb 4, 2026

View reviewed changes

Merge branch 'master' into chatagent-skill

dac75ad

Wendong-Fan reviewed Feb 4, 2026

View reviewed changes

Wendong-Fan added 2 commits February 5, 2026 18:56

enhance: Chatagent skills PR3732 (#3778)

84a64c0

Merge branch 'master' into chatagent-skill

5d7714f

Wendong-Fan merged commit 813ed0b into master Feb 5, 2026
14 checks passed

Wendong-Fan deleted the chatagent-skill branch February 5, 2026 10:57

feat: Chatagent skills #3732

feat: Chatagent skills #3732

Uh oh!

Conversation

fengju0213 commented Jan 21, 2026

Description

Checklist

Uh oh!

coderabbitai bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

lightaime commented Jan 23, 2026

Uh oh!

fengju0213 commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

waleedalzarooni left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zechengz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Wendong-Fan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Wendong-Fan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Wendong-Fan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coderabbitai bot commented Jan 21, 2026 •

edited

Loading

fengju0213 commented Jan 23, 2026 •

edited

Loading

Wendong-Fan left a comment •

edited

Loading