-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: Implement breakpoint resume functionality for failed tasks #3756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Implement breakpoint resume functionality for failed tasks #3756
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You designed an entire serialize → store → deserialize pipeline to maintain the agent’s context, but I think this workflow is overly complex and introduces a number of issues, for example, _save_breakpoint_history is invoked repeatedly, and exceptions can cause agent leakage.
Why don’t we simply avoid releasing the agent when a task fails and reuse the existing instance directly instead?
Done. Thanks @nitpicker55555 |
Description
Fixes #3739
Checklist
Go over all the following points, and put an
xin all the boxes that apply.Fixes #issue-numberin the PR description (required)pyproject.tomlanduv lockIf you are unsure about any of these, don't hesitate to ask. We are here to help!