Skip to content

Conversation

@fanzhidongyzby
Copy link
Contributor

Description

Fixes #3763

Changes

  • Add .md format support to MarkItDownLoader
  • Add type annotations to multiple methods in EarthScienceToolkit
  • Improve docstring in RetrievalToolkit with dynamic default values
  • Add corresponding unit tests for markdown file conversion

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTION guide (required)
  • I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
  • I have checked if any dependencies need to be added or updated in pyproject.toml and uv lock
  • I have updated the tests accordingly (required for a bug fix or a new feature)
  • I have updated the documentation if needed:
  • I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

Copilot AI review requested due to automatic review settings January 30, 2026 13:20
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 30, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #3763 by adding type annotations to multiple methods in EarthScienceToolkit that were missing parameter types. It also adds .md format support to MarkItDownLoader and improves the RetrievalToolkit docstring to use f-string interpolation for displaying default values dynamically.

Changes:

  • Added type annotations to 15 methods in EarthScienceToolkit to fix missing parameter types
  • Added .md format to the SUPPORTED_FORMATS list in MarkItDownLoader
  • Enhanced RetrievalToolkit docstring to use f-string interpolation for dynamic default value display
  • Added unit tests for markdown file conversion in MarkItDownLoader

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
camel/toolkits/earth_science_toolkit.py Added type annotations to 15 methods to ensure proper tool schema generation with type information
camel/loaders/markitdown.py Added .md extension to supported formats list for markdown file processing
camel/toolkits/retrieval_toolkit.py Changed docstring to use f-string formatting for dynamic constant interpolation
test/loaders/test_markitdown.py Added markdown file test case and updated test assertions to include the new format

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@Appointat Appointat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contributions. left some comments, for the code styles.

@fengju0213 fengju0213 added this to the Sprint 48 milestone Feb 1, 2026
@waleedalzarooni waleedalzarooni requested review from ZifengDing, a7m-1st and waleedalzarooni and removed request for ZifengDing February 2, 2026 08:11
Copy link
Collaborator

@waleedalzarooni waleedalzarooni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fanzhidongyzby,

Thanks for the great PR, I can't say I have anything to add other than what's already been said. Just make sure to resolve any linting and docstring warnings, I will get some feedback from a more senior maintainer over what to do with the rf string issue and we can go from there!

Copy link
Member

@Appointat Appointat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@waleedalzarooni waleedalzarooni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one quick amendment for the use of rf

Copy link
Collaborator

@a7m-1st a7m-1st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues from myside. Thanks @fanzhidongyzby

@fanzhidongyzby
Copy link
Contributor Author

No issues from myside. Thanks @fanzhidongyzby

Thanks, and I wander which version will be released including this pr, so I can update camel-ai dependency version in my project.

@waleedalzarooni waleedalzarooni merged commit c45d501 into camel-ai:master Feb 6, 2026
7 of 13 checks passed
Wendong-Fan pushed a commit that referenced this pull request Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Add tool param types in EarthScienceToolkit

6 participants