Fix resource leak, replace print with logger, fix O(n²) string concat #3803
+181
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n in loop - Fix file handle resource leak in openai_audio_models.py: use context managers (with statement) for open() calls at lines 245 and 262 - Replace print() with logger.warning() in hermes_function_formatter.py for proper logging of parse failures - Fix string concatenation in loop in search_agent.py: use list append and join pattern for better performance - Add tests for hermes formatter logging and audio model resource handling Co-authored-by: lightaime <[email protected]>
Copilot
AI
changed the title
[WIP] Review repo and create issues for suggested fixes and refactoring
Fix resource leak, replace print with logger, fix O(n²) string concat
Feb 8, 2026
waleedalzarooni
requested review from
4pmtong,
fengju0213 and
waleedalzarooni
Collaborator
waleedalzarooni
left a comment
waleedalzarooni
left a comment
There was a problem hiding this comment.
Just one comment, nothing major
| ) | ||
| final_prompt = final_prompt.format(query=query) | ||
| prompt = final_prompt + results | ||
| prompt = final_prompt + "\n".join(results) |
Collaborator
There was a problem hiding this comment.
Suggested change
| prompt = final_prompt + "\n".join(results) | |
| prompt = final_prompt + "\n".join(results) + "\n" |
This preserves the original behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeted fixes for three code quality issues found during repo review.
Resource leak in
openai_audio_models.pyFile handles from
open()were never closed inspeech_to_text(). Both the chunked and non-chunked paths leaked descriptors.print()instead of logging inhermes_function_formatter.pyParse failure warnings used
print(), bypassing the logging framework. Replaced withlogger.warning().O(n²) string concatenation in
search_agent.pyresults += result + "\n"in a loop replaced with list append +"\n".join().Tests
test_hermes_function_formatter.py— validates warnings go through logger, not stdouttest_openai_audio_resource_leak.py— validates file handle lifecycle with mocked OpenAI client💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.