-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Check terminal toolkit initial environment setting #3818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bytecii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Left some comments
|
Should we made these runtimes configurable from the initialzation of terminal toolkit? Having all the runtimes installed by default may be a bit too heavy. I would prefer having python runtime by default but the other ones are optional in the We can enable them all in eigent product. Do we have an idea what kind of tasks we need go and java. Also do we have an idea how much extra space will it take if we want to bundle all the language runtimes into the package? @Wendong-Fan @bytecii WDYT? |
bytecii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, let's maybe add a config to for example configure whether we need to include each language
|
@bytecii , can you please elaborate what type of changes should i do further? |
For example, for the TerminalToolkit initialization add args to something like allowed runtime etc. |
| # Check Go availability (auto-install if needed) | ||
| ensure_go_available(update_callback) | ||
|
|
||
| # Check Java availability (auto-install if needed) | ||
| ensure_java_available(update_callback) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like we directly discard the output installed path, then how would you ensure the shell command can find the correct path? Since we did not store the path in either os.environ["JAVA_HOME"] or os.environ["PATH"]
Description
Add Go and Java auto-install support for the terminal toolkit, as discussed in eigent-ai/eigent#932.
When the terminal toolkit initializes, it now automatically detects and downloads Go and Java runtimes if they aren't already installed:
go.dev/dl/(pinned to v1.23.6)~/.camel/runtimes/go/and~/.camel/runtimes/java/Changes
Closes : #932
closes: #3817
Checklist
Fixes #issue-numberin the PR description (required)pyproject.tomlanduv lock