-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: Support stream + tool call + structured output #3821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Support stream + tool call + structured output #3821
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Removed the _format_message_with_fallback method and its usages throughout the chat_agent.py file.
fengju0213
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice implementation. I noticed that we also added a fallback mechanism. I think retaining the native capabilities of the OpenAI SDK is already sufficient, and introducing a fallback would bring significant maintenance overhead. I suggest removing the related code.
Since this PR was submitted via a forked repository, I’m not able to submit a PR myself, so I made the changes directly in your PR.
|
Now Gemini and Claude are supported. |
…all-structured-output
Description
Fixes #3782
Checklist
Go over all the following points, and put an
xin all the boxes that apply.Fixes #issue-numberin the PR description (required)pyproject.tomlanduv lockIf you are unsure about any of these, don't hesitate to ask. We are here to help!