Skip to content

Conversation

@matt-dies-tenet3
Copy link
Contributor

@matt-dies-tenet3 matt-dies-tenet3 commented Jan 9, 2026

To resolve #673.

Removes the chardet dependency, because:

Therefore, chardet is not needed as a dependency of this package. This is helpful to users, who will need to install fewer dependencies now. Furthermore, chardet is LGPL licensed, which is copyleft and requires this package to share the same licensing if it remains a dependency.

@matt-dies-tenet3
Copy link
Contributor Author

matt-dies-tenet3 commented Jan 9, 2026

Appears that the tests are only failing for python3.8 during the installation of the library itself, related to the license = "MIT" line within the pyproject.toml. My best guess is that the PEPs that updated how the license is defined within this file didn't make it into python3.8, but have made it into python3.9+. Doesn't seem like this is an issue worth investigating as a part of this PR as it would be out-of-scope.

Other tests are passing elsewhere, as expected! This PR is probably ready for a merge, unless there are other changes that the maintainers would like me to address. If there are, I'm happy to look into them as needed.

@bosd bosd merged commit 05019ba into camelot-dev:master Jan 10, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove chardet dependency

2 participants