This repository was archived by the owner on May 14, 2026. It is now read-only.
better visual tests#3
Merged
Merged
Conversation
Test ResultsFast Test Results
Slow Test Results
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the visual testing framework to improve test organization and leverage the contextily library for basemap rendering. The changes move away from a centralized create_visual_map function to individual test methods that directly use matplotlib and contextily for creating transit system visualizations.
- Replaces the comprehensive visual snapshot testing approach with more granular, system-specific tests
- Introduces contextily-based basemap rendering directly in test methods
- Restructures test fixtures to load individual transit system data separately
Reviewed Changes
Copilot reviewed 3 out of 16 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tests/map/test_visual.py | Complete rewrite of visual tests with contextily integration and granular test structure |
| mise.toml | Adds sources configuration for the slow test task |
| core/map/main.py | Removes the create_visual_map function and fixes variable naming |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
345a30e to
2abed48
Compare
2abed48 to
3481fb3
Compare
📸 Visual Test Snapshots ComparisonNo visual changes detected - all snapshot tests passed! ✅ The visual snapshots match the expected references. No updates needed. |
1fdf92c to
2891572
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.