Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

better#4

Merged
cameronbrill merged 5 commits into
mainfrom
cb/better
Sep 9, 2025
Merged

better#4
cameronbrill merged 5 commits into
mainfrom
cb/better

Conversation

@cameronbrill
Copy link
Copy Markdown
Owner

@cameronbrill cameronbrill commented Sep 9, 2025

scan for secrets with infisical

remove gdal dependency

fmt

consistent commands

Copy link
Copy Markdown
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 9, 2025

Test Results

Fast Test Results

23 passed

Test results:
  test_extracts_name_from_dbg_lines_field: tests.map.test_main.TestExtractLineName
  test_extracts_name_from_lines_json_when_dbg_lines_empty: tests.map.test_main.TestExtractLineName
  test_extracts_first_label_from_multiple_lines: tests.map.test_main.TestExtractLineName
  test_falls_back_to_unknown_line_when_no_data: tests.map.test_main.TestExtractLineName
  test_returns_individual_line_names_not_combined: tests.map.test_main.TestExtractLineName
  test_fetches_data_successfully: tests.map.test_main.TestFetchGeojsonData
  test_raises_request_error_on_network_failure: tests.map.test_main.TestFetchGeojsonData
  test_separates_points_and_lines_correctly: tests.map.test_main.TestSeparateGeometries
  test_handles_empty_geometries: tests.map.test_main.TestSeparateGeometries
  test_creates_csv_with_basic_google_maps_format: tests.map.test_main.TestCreateStationsCsv
  test_uses_generic_station_names_not_labels: tests.map.test_main.TestCreateStationsCsv
  test_handles_empty_station_labels_gracefully: tests.map.test_main.TestCreateStationsCsv
  test_includes_description_with_station_names: tests.map.test_main.TestCreateStationsCsv
  test_preserves_polygon_geometry_for_google_maps_tinting: tests.map.test_main.TestExtractBoundaryLine
  test_handles_multipolygon_by_taking_largest: tests.map.test_main.TestExtractBoundaryLine
  test_creates_polygon_wkt_for_google_maps_tinting: tests.map.test_main.TestExtractBoundaryLine
  test_creates_kml_matching_working_google_format: tests.map.test_main.TestCreateSimpleKml
  test_creates_csv_with_wkt_and_description_columns: tests.map.test_main.TestCreateLinesCsv
  test_splits_multi_line_entries_into_separate_rows: tests.map.test_main.TestCreateLinesCsv
  test_handles_mixed_single_and_multi_line_entries: tests.map.test_main.TestCreateLinesCsv
  test_preserves_geometry_for_each_split_line: tests.map.test_main.TestCreateLinesCsv
  test_processes_real_subway_data_correctly: tests.map.test_main.TestIntegrationWithRealData
  test_main_processes_all_endpoints: tests.map.test_main.TestMainFunctionIntegration
This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.
Slow Test Results

7 passed

Test results:
  test_munich_boundary_basemap_overlay: tests.map.test_visual.TestMunichBasemap
  test_munich_boundary_different_providers: tests.map.test_visual.TestMunichBasemap
  test_munich_complete_transit_system: tests.map.test_visual.TestMunichCompleteSystem
  test_munich_complete_transit_system_voyager: tests.map.test_visual.TestMunichCompleteSystem
  test_munich_subway_system: tests.map.test_visual.TestMunichTransitSystems
  test_munich_tram_system: tests.map.test_visual.TestMunichTransitSystems
  test_munich_commuter_rail_system: tests.map.test_visual.TestMunichTransitSystems
This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 9, 2025

📸 Visual Test Snapshots Comparison

No visual changes detected - all snapshot tests passed! ✅

The visual snapshots match the expected references. No updates needed.

Copilot AI review requested due to automatic review settings September 9, 2025 18:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR focuses on improving project tooling and dependency management by adding secret scanning capabilities, removing the GDAL dependency, and standardizing command execution through the mise task runner.

  • Integrates Infisical CLI for secret scanning as part of the linting pipeline
  • Removes GDAL dependency and related system setup to simplify project dependencies
  • Standardizes CI/CD commands to use mise tasks instead of direct uv/pytest calls

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pyproject.toml Removes GDAL==3.4.1 dependency from project requirements
mise.toml Adds Infisical CLI tool, new lint task for secret scanning, and CI-specific test tasks
README.md Updates bullet point formatting from asterisks to hyphens
.github/workflows/ci.yaml Updates CI to install Infisical CLI and use mise tasks instead of direct commands
.github/actions/setup-python/action.yaml Removes GDAL system dependency installation and configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread mise.toml
Comment thread mise.toml
Comment thread mise.toml
@cameronbrill cameronbrill merged commit b60528a into main Sep 9, 2025
5 checks passed
@cameronbrill cameronbrill deleted the cb/better branch September 9, 2025 18:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants