Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sentinel backend #117

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add sentinel backend #117

wants to merge 3 commits into from

Conversation

julienCozo
Copy link

Add a backend to use sentinel redis cluster

@cameronmaske
Copy link
Owner

@julienCozo Thanks for the contribution.

Before this can get released, can you add some tests?
Here are some relevant examples that unit test and an integration test (if possible, I can't see a similar library that fakes a sentinel cluster like fakeredis, so this maybe tricker).

cameronmaske
cameronmaske reviewed Mar 25, 2020
View reviewed changes
celery_once/backends/sentinel.py Outdated

def __init__(self, settings):
"""
settings are like
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we clean up this docstring slightly or just remove it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@julienCozo julienCozo force-pushed the add_sentinel_backend branch from b1edf5f to b96593f Compare March 25, 2020 14:01
rassie
rassie reviewed Mar 26, 2020
View reviewed changes
.idea/.gitignore Outdated
Comment on lines 1 to 2
# Default ignored files
/workspace.xml
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think .idea directory belongs here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, sorry

@julienCozo julienCozo force-pushed the add_sentinel_backend branch from b96593f to 9a4b4bb Compare March 26, 2020 18:18
@julienCozo
Copy link
Author

@julienCozo Thanks for the contribution.

Before this can get released, can you add some tests?
Here are some relevant examples that unit test and an integration test (if possible, I can't see a similar library that fakes a sentinel cluster like fakeredis, so this maybe tricker).

Sentinel just return a StrictRedis instance, so tests are quite the sames. I don't have time for now but maybe later.

@e-gautier e-gautier mentioned this pull request Oct 24, 2021
Merged
@DoctorKatz
Copy link

Hi, how soon will be merged this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rassie rassie rassie left review comments

@cameronmaske cameronmaske cameronmaske left review comments

@e-gautier e-gautier e-gautier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@julienCozo @cameronmaske @DoctorKatz @rassie @e-gautier