Open
Conversation
Contributor
Author
|
@birm if you could review this, I would fix the conflicts at once and make it ready to merge |
birm
approved these changes
Nov 16, 2021
Member
birm
left a comment
There was a problem hiding this comment.
I've added a topic branch, as this configuration is enough different from the original that it's good to have the option. Maybe we'll switch which one is default at some point? Honestly, it's a little difficult for us to feel out what is useful to our users no matter how many meetings with them we have 😄
Of course, this is great work, and I thought I'd already pulled this into a topic branch. Apologies that it's taken this long.
| @@ -0,0 +1,23 @@ | |||
| # Role-Based Access Control Staging Area | |||
|
|
|||
| **Note**: this pull request is not initiated to be merged, but to have a single point status check of the project progress. | |||
Member
There was a problem hiding this comment.
Suggested change
| **Note**: this pull request is not initiated to be merged, but to have a single point status check of the project progress. |
(or the entire file?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google Summer of Code 2021 Wrap-up
Objectives
Role Bases system
APIS
Architecture
There has been a fundamental change in the way the application is structured. Even when I was limited on time, I have tried to club together similar functionality in form of modules or services (located in /services). This allows easy testing and a single point of contact for all operations. Earlier there was a lot of redundancy in the codebase, which is now removed as all calls are made to a single service and code is not duplicated.
Dependency
In order for the cache system to work, a new dependency of redis had to be added. The changes in the deployment will be needed to include a redis container for the cache service.
Note