save voxelsize as explictit parameters rather than np array#407
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
==========================================
- Coverage 85.80% 83.72% -2.09%
==========================================
Files 56 56
Lines 9929 9660 -269
==========================================
- Hits 8520 8088 -432
- Misses 1409 1572 +163 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how voxel size parameters are handled in the reconstruction toolbox and removes custom YAML serialization logic for
numpyarrays. The changes improve code clarity and simplify the import/export process by eliminating unnecessary complexity.Refactoring voxel size handling:
_export_settings(src/napari_stress/_reconstruction/toolbox.py): Replaced thevoxelsizedictionary key, which previously stored anumpyarray, with individual keys (voxelsize_z,voxelsize_y,voxelsize_x) for better readability and maintainability._import_settings(src/napari_stress/_reconstruction/toolbox.py): Updated the code to retrieve individual voxel size values (voxelsize_z,voxelsize_y,voxelsize_x) instead of indexing into anumpyarray, aligning with the new export format.Simplifying YAML serialization:
import_settings(src/napari_stress/_utils/import_export_settings.py): Removed the custom YAML constructor fornumpyarrays, as it is no longer needed due to the refactored voxel size handling.export_settings(src/napari_stress/_utils/import_export_settings.py): Removed the custom YAML representer fornumpyarrays, simplifying the export logic.