Skip to content

Fix short trace bug #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maarzt wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix short trace bug #421

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdc3b68
Refactoring, more efficient filtering of NaN values
maarzt Jul 16, 2025
a4dacca
Fix surface reconstruction when trace length is less than 5
maarzt Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/napari_stress/_reconstruction/fit_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ def _fancy_edge_fit(
DESCRIPTION.
"""
params = _function_args_to_list(selected_edge_func)[1:]
array = [x for x in array if not np.isnan(x)] # filter out nans
array = array[~np.isnan(array)] # filter out nans
try:
if selected_edge_func == _sigmoid:
# estimate parameters and trim intensity array
Expand Down Expand Up @@ -252,8 +252,7 @@ def estimate_fit_parameters(intensity):
"""
# Check if there are too few points
if len(intensity) < 5:
print("Warning: Too few points in trace (length < 5)")
return [np.nan] * 5, intensity, intensity
raise ValueError("Warning: Too few points in trace (length < 5)")

# Calculate the first derivative (dY)
dY = 0.5 * (
Expand Down
Loading