Change WITHOUT_DEMO (deprecated) to WITH_DEMO in odoo.cfg.tmpl

[cyrilmanuel]

option is deprecated in 19.0 :

https://camptocamp.atlassian.net/browse/BSPLA-91

[florentx]

It is not obvious to me that option is deprecated.

There is a new option --with-demo but --without-demo is still fully supported.

Significant change is that --without-demo="" is no longer accepted. It is parsed wrong. It should be changed to an explicit boolean, like `--without-demo=False" probably. To test.

https://odoo.com/documentation/19.0/developer/reference/cli.html?highlight=--without-demo#cmdoption-odoo-bin-with-demo

[florentx]

Proposal, which might cover other use cases as well (e.g.: running tests):

• fix: Odoo 19, set with_demo option #390

[leemannd]

Hello @florentx ,
There are warnings when launching an odoo 19.

It comes from:

• [IMP] config: make demo data opt-in odoo/odoo#188826
• [IMP] core: no longer load demo data by default odoo/odoo#194585

[leemannd]

@cyrilmanuel , we are not using the branch master for the project planair. We need this into the branch https://github.com/camptocamp/docker-odoo-project/tree/release-4.5.X

[florentx]

• [IMP] core: no longer load demo data by default odoo/odoo#194585

I see now upstream PR, that I didn't see earlier.

However, option without_demo = ... is supported, and there is no warning, after I apply #390.

Since bin/docker-entrypoint.sh is cross-compatible 14.0 to 19.0, and uses WITHOUT_DEMO env var, I suggest to keep using it for the time being, so that images for Odoo 18 and older still behave right.

We might reconsider it later.

[leemannd]

For the time beeing it is cross compatible. But we could adapt it so it will work out of the box when it won't be.

As we are always on the rush when there is a new odoo version. I think we need to adapt it when we have the time and not when we are on a rush.

[florentx]

I've changed PR #390 for Odoo 19, to use with_demo = .

@leemannd

[florentx]

@cyrilmanuel , we are not using the branch master for the project planair. We need this into the branch https://github.com/camptocamp/docker-odoo-project/tree/release-4.5.X

Port to 4.5 branch:

• fix: Odoo 19, set configuration option with_demo - release-4.5.X #395