feat: Odoo 19, adjust file permissions #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 24, 2025
ivantodorovich
approved these changes
Dec 29, 2025
| USER odoo | ||
| RUN python3 -m venv /odoo/.venv --system-site-packages | ||
| RUN umask 007 \ | ||
| && python3 -m venv /odoo/.venv --system-site-packages |
Member
There was a problem hiding this comment.
Why the umask here (and following steps) ?
Contributor
Author
There was a problem hiding this comment.
Actually all the permissions are set to 660/770 for files copied to the image (lines 60 to 65 above).
We set the umask before installing virtualenv and python packages, so they are created with same permissions.
I don't think it makes a difference at the end, even regarding security. So if we'd like the Dockerfile to be simpler, we can remove the umask instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.