Skip to content

Conversation

@AlitaBernachot
Copy link
Collaborator

This PR adds a tile load function error handler also for VectorTileLayer/VectorTile/MVT (mapbox vector tiles) wich is used for Gprf's "TMS".

@AlitaBernachot AlitaBernachot force-pushed the fix-tms-source-error branch from a7af71c to 6d69952 Compare June 4, 2025 06:19
Copy link
Member

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! also for the simplification 🙏

@AlitaBernachot
Copy link
Collaborator Author

oh wait, reading again my code i have a small doubt about https://github.com/camptocamp/geospatial-sdk/pull/28/files#diff-0b30aedb7e9a5ebe8ea53b20abbb66f80186473926617a659c600b2c8ff171fbR50, the layer is not yet iniatialized at this point, but it is afterwards when tileLoadFunction is called later, it works, but is it ok to keep it as is? 🤔

@jahow
Copy link
Member

jahow commented Jun 4, 2025

oh wait, reading again my code i have a small doubt about https://github.com/camptocamp/geospatial-sdk/pull/28/files#diff-0b30aedb7e9a5ebe8ea53b20abbb66f80186473926617a659c600b2c8ff171fbR50, the layer is not yet iniatialized at this point, but it is afterwards when tileLoadFunction is called later, it works, but is it ok to keep it as is? 🤔

Oh sorry, I thought it was the layer model that was given. I'm not 100% sure it will work, maybe try adding a more complete unit test?

@AlitaBernachot
Copy link
Collaborator Author

Oopsy i was too fast on that one! I set the tileLoadfunction for Image to the VectorTile tileLoadFunction... this handler may need some more work.
I think i have managed to fix the issue on gn-ui side, so i probably won't need this evolution.
Sorry for this false alert. I'll try to have a look later if this is a needed feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants