[16.0][FIX] session_redis: add incompatibility to auth_session_timeout#491
Merged
[16.0][FIX] session_redis: add incompatibility to auth_session_timeout#491
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 16.0 #491 +/- ##
==========================================
+ Coverage 36.05% 36.42% +0.37%
==========================================
Files 33 37 +4
Lines 760 829 +69
Branches 106 107 +1
==========================================
+ Hits 274 302 +28
- Misses 480 521 +41
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
``session_redis`` is not compatible with ``auth_session_timeout``. ``session_redis`` overrides property ``odoo.http.Application.session_store`` by returning a ``RedisSessionStore`` object instead of a ``odoo.http.FilesystemSessionStore`` object. ``auth_session_timeout`` expects ``odoo.http.Application.session_store`` object to define method ``get_session_filename()``, which does not exist for ``RedisSessionStore`` objects. This results in an ``AttributeError`` that prevents user authentication, and Odoo becomes inaccessible.
SilvioC2C
force-pushed
the
16.0-fix-session_redis
branch
from
28c1b02 to
da0897b
Compare
florentx
approved these changes
May 8, 2025
vvrossem
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-port of #488 and #489