[IMP] otools-migrate-db: improve error handling #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle exceptions coming from DB operations (create, drop, restore) differently than ones that could happen in `migrate-db`. Before this commit, we could get misleading error messages telling to check the migration log (produced by `migrate-db`) while the issue was happening before that, when the DB was dropped and restored because an open connection was blocking the operation.
sebalix
force-pushed
the
migrate-db-imp-exception-handling
branch
from
8526942 to
6148b62
Compare
henrybackman
approved these changes
Oct 8, 2025
twalter-c2c
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle exceptions coming from DB operations (create, drop, restore) differently than ones that could happen in
migrate-db.Before this commit, we could get misleading error messages telling to check the migration log (produced by
migrate-db) while the issue was happening before that, when the DB was dropped and restored because an open connection was blocking the operation.Output:
TODO
HOWTO test this PR