Improve convert

[gurneyalex]

• fix stale warning
• take care of the ADDONS_PATH conversion

closes: #82

[leemannd]

/odoo/src/odoo/odoo/addons I don't remember seeing it. It exists or is it a typo?

[gurneyalex]

it's the path of the base addons. Not sure why I had issues without this. I'll double check

[sebalix]

/odoo/src/addons + /odoo/src/odoo/addons should be enough IMO, the other one doesn't exist

[leemannd]

The replace seems strange. I may be missing something.

[gurneyalex]

there is 1 directory in the "old style" image, and I had to replace it with the 2 addons directories of Odoo (addons/ and odoo/addons/ ) in the new style image

[leemannd]

Looks good. I only have one point on which I'm not sure.

[florentx]

Now pathlib is mandatory for this repo.

Suggested change

	shutil.move("odoo/Dockerfile", "Dockerfile.bak")
	old_env_lines = []
	with open("Dockerfile.bak") as old_dockerfile:
	found_env = False
	for line in old_dockerfile:
	old_dockerfile = Path("odoo/Dockerfile").rename("Dockerfile.bak")
	new_dockerfile = Path("Dockerfile")
	old_env_lines = []
	found_env = False
	with old_dockerfile.open() as fobj:
	for line in fobj:

[florentx]

Suggested change

	with open("Dockerfile") as new_dockerfile:
	found_env = False
	for line in new_dockerfile:
	found_env = False
	with new_dockerfile.open() as fobj:
	for line in fobj:

[florentx]

Suggested change

	with open("Dockerfile", "w") as new_dockerfile:
	new_dockerfile.writelines(new_docker_file_lines)
	with new_dockerfile.open("w") as fobj:
	fobj.writelines(new_docker_file_lines)