Run promise in isReady instead of constructor#139
Open
mborne wants to merge 1 commit intocamptocamp:mainfrom
Open
Run promise in isReady instead of constructor#139mborne wants to merge 1 commit intocamptocamp:mainfrom
mborne wants to merge 1 commit intocamptocamp:mainfrom
Conversation
…msEndpoint and WmtsEndpoint (refs camptocamp#138)
Author
|
Tell me if you are interrested in some hardening like the following in this PR or another one :
Something like : class WfsEndpoint {
/**
* A Promise which resolves to the endpoint information.
*/
getServiceInfo() {
return this._info;
}
}=> class WfsEndpoint {
// ...
ensureIsReady(){
if ( ! this._info ){
throw new EndError("isReady() must be resolved before calling WfdEndpoint methods")
}
}
/**
* Get the endpoint information.
*/
getServiceInfo(): GenericEndpointInfo {
this.ensureIsReady();
return this._info;
}
} |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It will avoid
unhandledRejectionfrom the constructor(refs #138)