Skip to content

Adding json type to task variables #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

fliot
Copy link

@fliot fliot commented Oct 20, 2021

Tiny changes to input/output Json variables.

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 4 committers have signed the CLA.

❌ rutscs
❌ svenrr
❌ fliot
❌ yogeshrnaik


rutscs seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@fliot
Copy link
Author

fliot commented Oct 20, 2021

Removing debug

@fliot
Copy link
Author

fliot commented Oct 29, 2021

Hi,
I must confess I do not understand the branching workflow you are following,
Json Task variables is a very interesting feature, why don't you add it into the master branch ?
Please, explain us.

@yogeshrnaik
Copy link
Collaborator

Hi, I must confess I do not understand the branching workflow you are following, Json Task variables is a very interesting feature, why don't you add it into the master branch ? Please, explain us.

Sorry for the delay. Thank you for the great feature. I have approved the PR. Please fix the failing build/tests before merging.

@celanthe
Copy link
Contributor

celanthe commented Nov 2, 2021

Hi there @yogeshrnaik! As these commits are from back in late August, they won't count towards the Camunda Hacktoberfest project. Would you be so kind as to remove the 'hacktoberfest-accepted' issue label?

@rutscs if you would be so kind as to sign the CLA, that would be amazing. Thank you both so much! Alternately, @svenrr or @yogeshrnaik can re-run the CLA bot to remove that user from the automated check if they are no longer a contributor to the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants