feat: filter process instances by multiple variables and return bpmn groups, documentation, and extensionProperties in process details#496
Open
HMubaireek wants to merge 21 commits intocamunda-community-hub:mainfrom
Conversation
…umentation for elements
feat: get process instances by variable name and value
…s-documentation-group-elements feat: return group elements, and return extension properties with documentation for elements
…le-variables feat: filter process instances by multiple variables
…le-variables feat: add filter operation to variables filter
…le-variables feat: add extensionElements to return properties and ioMapping
Contributor
|
@HMubaireek thank you for your contribution. 🎉 I'll have a look at the changes next week. 👀 |
saig0
requested changes
Jun 12, 2024
Contributor
saig0
left a comment
There was a problem hiding this comment.
@HMubaireek I did a quick review of your changes. Looks good in general. 🚀
I have concerns about the performance of the variables filtering and a few minor suggestions.
To speed up the review, please split up the changes into two PRs for the new BPMN element properties and the variables filtering. And, add some test cases to verify the behavior. 🍪
I'm sorry for the delay. Looking forward to the new features. ✨
…ception fix: concurrent modifications exception
fix: slow response to variables request
…tance-key fix(zeeqs): collision on element instance key
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following features:
bpmn:groupelements since before it was only returning elements of type FlowElementRelated issues
For filtering by variables:
closes # #16
For returning documentation, group, and extensionProperties:
closes # #356