fix: enhance plugin initialization by adding required files and updating templates#107
Merged
fix: enhance plugin initialization by adding required files and updating templates#107
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the plugin initialization system by adding missing template files, updating TypeScript configuration for better Node.js ESM support, and adding comprehensive test coverage for scaffolded files.
Changes:
- Added test coverage to verify all required files are scaffolded during plugin initialization
- Updated TypeScript module resolution from ES2022 to NodeNext for proper Node.js ESM support
- Added
@camunda8/clias a devDependency to plugin templates for TypeScript type support - Created gitignore template file (stored as 'gitignore' to survive npm publish)
- Enhanced package.json exports to include TypeScript type definitions
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/plugin-lifecycle.test.ts | Added test to verify all required files exist after plugin initialization |
| src/templates/tsconfig.json | Updated module and moduleResolution to NodeNext for proper Node.js ESM support |
| src/templates/package.json | Added @camunda8/cli devDependency and alphabetized dependencies for TypeScript type support |
| src/templates/gitignore | New template file with minimal gitignore rules (node_modules and source maps) |
| src/commands/plugins.ts | Fixed template file reference from '.gitignore' to 'gitignore' with explanatory comment |
| package.json | Enhanced runtime exports with explicit TypeScript type definitions path |
Collaborator
Author
|
(ping back to https://github.com/camunda/product-hub/issues/2638 for ref) |
|
This has been released in 2.3.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.