feat(diagram-converter): variableName filter not supported#1045
feat(diagram-converter): variableName filter not supported#1045
Conversation
venetrius
force-pushed
the
1040-remove-variableNamesFilter
branch
from
dd50eaa to
66ca925
Compare
| delete-variable-event-not-supported.message=Variable event 'delete' is not supported in conditional event filter on '{{ elementId }}'. C8 only supports 'create' and 'update'. IMPORTANT: The condition will no longer trigger when variables are deleted. Please redesign if your process relies on delete events (e.g., set variables to null instead of deleting them). | ||
| delete-variable-event-not-supported.severity=TASK | ||
| delete-variable-event-not-supported.link=https://docs.camunda.io/docs/components/modeler/bpmn/events/ | ||
| delete-variable-event-not-supported.link=https://docs.camunda.io/docs/components/modeler/bpmn/conditional-events/#variable-filters |
There was a problem hiding this comment.
Updated links for conditional event in this PR as docs page only have been added last week.
Opening the links now returns 404 unless editing docs/components/ -> docs/next/components/ as the docs are only part of the next release.
I think this is acceptable. Other options would be to use staging doc link here and update it after next alfa or just before the minor release.
…aluation message" This reverts commit e4b9b6e.
venetrius
changed the title
joaquinfelici
left a comment
joaquinfelici
left a comment
There was a problem hiding this comment.
Looks good 👍
Added a couple of minor comments, but I'm approving.
Any doc update needed for this?
diagram-converter/core/src/main/resources/message-templates.properties
Outdated
Show resolved
Hide resolved
| context.addMessage(MessageFactory.variableNameFilterOnConditionalEvent(elementId)); | ||
| } | ||
|
|
||
| if (StringUtils.isBlank(variableEvents)) { |
There was a problem hiding this comment.
Question: Should this be an else if? Or can both be true?
There was a problem hiding this comment.
They are checking different fields variableName vs variableEvents both values are optional so both checks can be true.
Co-authored-by: Joaquín <165814090+joaquinfelici@users.noreply.github.com>
2 participants
Related to: #1045
Pull Request Template
Description
Type of Change
Testing Checklist
Black-Box Testing Requirements
DbClient,IdKeyMapper,..impl..packages except logging constants)ArchitectureTestvalidates these rules)Test Coverage
Architecture Compliance
Run architecture tests to ensure compliance:
mvn test -Dtest=ArchitectureTestIf architecture tests fail, refactor your tests to use:
LogCapturerfor log assertionscamundaClient.new*SearchRequest()for C8 queriesDocumentation
Checklist
Related Issues