Skip to content

chore(migrator): pin CPT to 8.9-SNAPSHOT#1078

Merged
yanavasileva merged 1 commit intomainfrom
run-against-latest-8.9-snapshot
Mar 3, 2026
Merged

chore(migrator): pin CPT to 8.9-SNAPSHOT#1078
yanavasileva merged 1 commit intomainfrom
run-against-latest-8.9-snapshot

Conversation

@yanavasileva
Copy link
Member

Pull Request Template

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Test-only changes (no production code changes)

Testing Checklist

Black-Box Testing Requirements

  • Tests follow black-box testing approach: verify behavior through observable outputs (logs, C8 API queries, real-world skip scenarios)
  • Tests DO NOT access implementation details (DbClient, IdKeyMapper, ..impl.. packages except logging constants)
  • Architecture tests pass (ArchitectureTest validates these rules)

Test Coverage

  • Added tests for new functionality
  • Updated tests for modified functionality
  • All tests pass locally

Architecture Compliance

Run architecture tests to ensure compliance:

mvn test -Dtest=ArchitectureTest

If architecture tests fail, refactor your tests to use:

  • LogCapturer for log assertions
  • camundaClient.new*SearchRequest() for C8 queries
  • Real-World skip scenarios (e.g., migrate children without parents)

Documentation

  • Updated TESTING_GUIDELINES.md if adding new test patterns
  • Added Javadoc comments for public APIs
  • Updated README if user-facing changes

Checklist

  • Code follows project style guidelines
  • Self-reviewed the code
  • Added comments for complex logic
  • No new compiler warnings
  • Dependent changes have been merged

Related Issues

@yanavasileva yanavasileva self-assigned this Mar 3, 2026
@yanavasileva yanavasileva requested a review from venetrius March 3, 2026 11:28
Copy link
Member

@venetrius venetrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yanavasileva yanavasileva merged commit 2120aca into main Mar 3, 2026
27 checks passed
@yanavasileva yanavasileva deleted the run-against-latest-8.9-snapshot branch March 3, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants