feat(zeebe): support Job Corrections in complete command fixes #347 #348
+240
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korthout
reviewed
Jan 15, 2025
Comment on lines
+49
to
+53
| const res1 = await job.completeWithJobResult({ | ||
| variables: {}, | ||
| result: { | ||
| denied: true, | ||
| }, |
There was a problem hiding this comment.
💭 Given the test case (the process has a service task for which this job worker code will run) this code may eventually break.
Job result is at this time only meant to be used for User Task Listeners.
For now, we allow regular job completions with a job result ignoring the result. However, in the future we may add validations against it.
🔧 As a more durable test case, please consider a Camunda User Task with a completing task listener. You can then try to complete the user task, which creates a job that you can activate and complete with a job result.
korthout
reviewed
Jan 15, 2025
korthout
reviewed
Mar 5, 2025
Comment on lines
+509
to
+515
| /** Since Camunda 8.8 */ | ||
| result?: JobResult | ||
| } | ||
|
|
||
| /** | ||
| * Since Camunda 8.7 | ||
| */ |
There was a problem hiding this comment.
Suggested change
| /** Since Camunda 8.8 */ | |
| result?: JobResult | |
| } | |
| /** | |
| * Since Camunda 8.7 | |
| */ | |
| /** Since Camunda 8.8 */ | |
| result?: JobResult | |
| } | |
| /** | |
| * Since Camunda 8.8 | |
| */ |
Comment on lines
+516
to
+522
| export interface JobResult { | ||
| // Indicates whether the worker denies the work, i.e. explicitly doesn't approve it. | ||
| // For example, a Task Listener can deny the completion of a task by setting this flag to true. | ||
| // In this example, the completion of a task is represented by a job that the worker can complete as denied. | ||
| // As a result, the completion request is rejected and the task remains active. | ||
| // Defaults to false. | ||
| denied?: boolean |
There was a problem hiding this comment.
🔧 There's also a new deniedReason?: string added:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
[Describe your changes here]
Type of change
Checklist
alphabranchFurther comments
[If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...]