ci: add Vault-based org membership check for community notifications#792
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Slack “community notification” GitHub Actions workflow to support a more reliable org-membership check (including private memberships) by providing Vault credentials to the upstream reusable workflow in camunda/sdk-infra.
Changes:
- Pass
author-associationexplicitly into the reusable workflow (to avoid event-context inheritance edge cases). - Provide Vault connection/AppRole secrets (
VAULT_ADDR,VAULT_ROLE_ID,VAULT_SECRET_ID) so the reusable workflow can mint a GitHub App token and check/orgs/{org}/members/{username}.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Vault integration to the community notification workflow so it can reliably detect org members — including those with private membership — and skip false-positive community alerts.
Background
GitHub's
author_associationfield returnsCONTRIBUTORinstead ofMEMBERfor org members who have base-permission-only access (no team/direct collaborator assignment). The upstream reusable workflow insdk-infranow uses thecamunda-sdk-automationGitHub App (via Vault) to check the authenticated/orgs/{org}/members/{username}endpoint.Changes
author-associationexplicitly to the reusable workflow (defense-in-depth)VAULT_ADDR,VAULT_ROLE_ID,VAULT_SECRET_ID) to enable the authenticated org membership checkPrerequisites
camunda-sdk-automationGitHub App installed on this reposdk-infrav1 tag updated