This repository was archived by the owner on Nov 4, 2025. It is now read-only.
"Not In" query for task definition keys #4972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds functionality to filter tasks excluding definition key from a given list related to camunda#4968
- adds filter field for task definition key not in query statements to rest api related to camunda#4968
2 tasks
venetrius
suggested changes
Jul 2, 2025
Member
venetrius
left a comment
venetrius
left a comment
There was a problem hiding this comment.
👍 Looks really goo to me!
I spotted one unused import and I had a few nitpick., otherwise looks good. Also tested locally and verified that it works as intended.
engine-rest/engine-rest-openapi/src/main/templates/lib/commons/task-query-params.ftl
Outdated
Show resolved
Hide resolved
engine/src/test/java/org/camunda/bpm/engine/test/api/task/TaskQueryTest.java
Outdated
Show resolved
Hide resolved
...napi/src/main/templates/models/org/camunda/bpm/engine/rest/dto/runtime/task/TaskQueryDto.ftl
Outdated
Show resolved
Hide resolved
- improve descriptions related to camunda#4968 Co-authored-by: Gergely Juhasz <[email protected]>
- remove unused import related to camunda#4968 Co-authored-by: Gergely Juhasz <[email protected]>
Contributor
Author
|
Hi @venetrius, Thanks for the review and your feedback! I applied your suggestions. Best, |
venetrius
approved these changes
Jul 7, 2025
Member
venetrius
left a comment
venetrius
left a comment
There was a problem hiding this comment.
👍 Looks good to me!
Thanks for applying the changes
Member
|
Changes passed CI: #5267 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4968