This repository was archived by the owner on Nov 4, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(variableQuery): add variable creationtime support for queries #5377
Merged
+78
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
66384f6 to
c0e5643
Compare
yanavasileva
suggested changes
Aug 28, 2025
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Base is good, please check xml and test.
engine/src/main/java/org/camunda/bpm/engine/impl/HistoricVariableInstanceQueryImpl.java
Show resolved
Hide resolved
...e/src/main/resources/org/camunda/bpm/engine/impl/mapping/entity/HistoricVariableInstance.xml
Show resolved
Hide resolved
engine/src/test/java/org/camunda/bpm/engine/test/history/HistoricVariableInstanceTest.java
Show resolved
Hide resolved
74be49c to
06176f8
Compare
Member
|
@HeleneW-dot, mysql failed. I attempted to fix but without success as it failed again. |
7707d5a to
269625a
Compare
Contributor
Author
|
@yanavasileva Fixed now, ready for re review 🙏 |
yanavasileva
approved these changes
Sep 1, 2025
Member
yanavasileva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sorry for the back and forth on this one.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #5376