Skip to content
This repository was archived by the owner on Nov 4, 2025. It is now read-only.

Conversation

@HeleneW-dot
Copy link
Contributor

related to #5376

@HeleneW-dot HeleneW-dot self-assigned this Aug 27, 2025
@HeleneW-dot HeleneW-dot added the ci:rest-api Runs extra builds for the REST API (currently only WLS compatibility builds). label Aug 27, 2025
@HeleneW-dot HeleneW-dot added ci:all-db Runs the builds for all databases. and removed ci:rest-api Runs extra builds for the REST API (currently only WLS compatibility builds). labels Aug 27, 2025
@HeleneW-dot HeleneW-dot force-pushed the 5376-variable-creationdate-query branch 2 times, most recently from 66384f6 to c0e5643 Compare August 27, 2025 04:36
@HeleneW-dot HeleneW-dot changed the title feat(API): add variable creationdate support for queries feat(variableQuery): add variable creationdate support for queries Aug 27, 2025
@HeleneW-dot HeleneW-dot changed the title feat(variableQuery): add variable creationdate support for queries feat(variableQuery): add variable creationtime support for queries Aug 28, 2025
Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Base is good, please check xml and test.

@HeleneW-dot HeleneW-dot force-pushed the 5376-variable-creationdate-query branch from 74be49c to 06176f8 Compare August 29, 2025 08:27
@yanavasileva
Copy link
Member

@HeleneW-dot, mysql failed. I attempted to fix but without success as it failed again.
The test needs to be adjusted to disregard seconds, I think. Ref: link

@HeleneW-dot HeleneW-dot force-pushed the 5376-variable-creationdate-query branch from 7707d5a to 269625a Compare August 30, 2025 09:53
@HeleneW-dot
Copy link
Contributor Author

@yanavasileva Fixed now, ready for re review 🙏

Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Sorry for the back and forth on this one.

@HeleneW-dot HeleneW-dot merged commit dcee0db into master Sep 2, 2025
7 checks passed
@HeleneW-dot HeleneW-dot deleted the 5376-variable-creationdate-query branch September 2, 2025 02:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ci:all-db Runs the builds for all databases.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants