-
Notifications
You must be signed in to change notification settings - Fork 1.7k
chore(ci): remove unsupported env #5447
Conversation
venetrius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Should we also remove references from the camunda-bpm-platform/Jenkinsfile?
venetrius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had one more question
Jenkinsfile
Outdated
| } | ||
| } | ||
| stage('engine-IT-tomcat-9-postgresql-142') { | ||
| stage('engine-IT-tomcat-9-postgresql-170') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Do we still need stages with tomcat-9?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the ticket description:
can we "just" keep the CI structure and replace Tomcat 9 with 11?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which also might mean that we keep only the CI but remove the tomcat 9 webapp module. 🤔 I will check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right!
venetrius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me!
Should this wait until the end of code freeze before merging? It does not change behaviour but can effect the CI.
venetrius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me
#5028