Skip to content

WIP Add fuzzy search to popup menu and search#367

Draft
philippfromme wants to merge 1 commit intomainfrom
fuzzy-search
Draft

WIP Add fuzzy search to popup menu and search#367
philippfromme wants to merge 1 commit intomainfrom
fuzzy-search

Conversation

@philippfromme
Copy link
Contributor

No description provided.

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jun 5, 2024
@philippfromme philippfromme changed the title WIP feat(popup-menu): add fuzzy search to popup menu WIP Add fuzzy search to popup menu and search Jun 5, 2024
@philippfromme philippfromme added the backlog Queued in backlog label Jun 24, 2024 — with bpmn-io-tasks
@philippfromme philippfromme removed the in progress Currently worked on label Jun 24, 2024
@nikku nikku added the ready Ready to be worked on label Nov 4, 2024 — with bpmn-io-tasks
@nikku nikku removed the backlog Queued in backlog label Nov 4, 2024
@philippfromme philippfromme added the backlog Queued in backlog label Nov 5, 2024 — with bpmn-io-tasks
@philippfromme philippfromme removed the ready Ready to be worked on label Nov 5, 2024
@nikku
Copy link
Member

nikku commented Nov 20, 2024

This can in principal be integrated on top of #393.

@philippfromme
Copy link
Contributor Author

philippfromme commented Nov 22, 2024

I've updated the pull request. However, there are some search features that break with a simple fuzzy search integration:

  1. Matching regardless of word order
brave_WQES5jDD9u
  1. Matching words across keys
brave_6DkVHCWDQz

Some additional work is needed to make these work with fuzzy search.

@nikku
Copy link
Member

nikku commented Nov 22, 2024

Thanks for the update. I guess we could even provide this as a plug-in and see if it is an improvement. The first one is covered by our existing search behavior, already:

image

@philippfromme
Copy link
Contributor Author

Yes, the two features I mentioned work inthe current search implementation (screenshots from demo.bpmn.io) but not with a simple integration of fuzzy search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backlog Queued in backlog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants