feat(aks): evolve from embedded to operators for ref arch#1903
feat(aks): evolve from embedded to operators for ref arch#1903marcel-dias wants to merge 3 commits intomainfrom
Conversation
Signed-off-by: Marcel Dias <marcel.dias@camunda.com>
🔀 Skip Workflow ChecklistCheck the boxes below to skip specific workflows for this PR. Global options
Individual workflows
This checklist is automatically managed. Checked items will skip the corresponding workflow. |
There was a problem hiding this comment.
Pull request overview
This pull request migrates the Azure AKS single-region test workflow from using embedded Elasticsearch (deployed via Helm chart) to operator-based Elasticsearch using the Elastic Cloud on Kubernetes (ECK) operator. This change aligns the AKS workflow with the existing ROSA workflow pattern and modernizes the infrastructure management approach.
Changes:
- Removed legacy
elasticsearch.enabled: trueconfiguration from Helm values files, as Elasticsearch is now managed by the ECK operator - Added ECK operator deployment and cleanup steps to the workflow, including proper action triggers for automated testing
- Updated test configuration to pass the ECK-provisioned Elasticsearch service name (
elasticsearch-es-http:9200) to the test action
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/azure_kubernetes_aks_single_region_tests.yml |
Added ECK operator workflow triggers, deployment step before Keycloak, cleanup step, and elasticsearch-service-name parameter to tests |
azure/kubernetes/aks-single-region/helm-values/values-domain.yml |
Removed embedded Elasticsearch configuration and added documentation about ECK operator overlay |
azure/kubernetes/aks-single-region/helm-values/values-no-domain.yml |
Removed embedded Elasticsearch configuration and added documentation about ECK operator overlay |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
azure/kubernetes/aks-single-region/helm-values/values-domain.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Marcel Dias <233598+marcel-dias@users.noreply.github.com>
There was a problem hiding this comment.
One small comment, otherwise lgtm
Will do a second review with the doc to verify consistency
@marcel-dias please fix #1903 (comment) before merge
Signed-off-by: Marcel Dias <marcel.dias@camunda.com>
feat(aks): evolve from embedded to operators for ref arch
see ticket details https://github.com/camunda/team-infrastructure-experience/issues/1029
This pull request introduces support for deploying Elasticsearch via the ECK (Elastic Cloud on Kubernetes) operator in the Azure AKS single-region test workflow. The changes remove legacy Elasticsearch configuration from Helm values files and update the workflow to use operator-based overlays and actions for deployment and cleanup. This streamlines Elasticsearch management and aligns it with operator-based practices.
Workflow integration for ECK Elasticsearch:
.github/actions/kubernetes-eck-operator,.github/actions/kubernetes-eck-operator-cleanup, andgeneric/kubernetes/operator-based/elasticsearchto the workflow triggers, enabling proper detection and execution for ECK operator-related changes.Configuration changes:
elasticsearch.enabled: truesettings fromvalues-domain.ymlandvalues-no-domain.yml, clarifying that Elasticsearch is now managed via the ECK operator and configured through a dedicated overlay file. [1] [2] [3] [4]Test environment enhancements:
elasticsearch-service-nameto test action inputs, ensuring tests can connect to the correct Elasticsearch service provisioned by the operator.