Switch EKS tests to SPOT instances#2096
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
Co-authored-by: leiicamundi <153937047+leiicamundi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Switch to SPOT instances for tests
Switch EKS tests to SPOT instances
Mar 20, 2026
Contributor
|
the agent took the instructions very literal 😁. |
Contributor
|
@Langleu the result of this little experience around agents is not successful, it does work only for small things |
Contributor
|
I mean it's not that wrong, it just applied it to everything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All EKS test clusters were using
ON_DEMANDinstances. Switch to SPOT across all test variants to reduce costs, consistent with the approach already used inaws/modules/fixtures/fixtures.default.eks.tfvars.Changes
eks-single-region+eks-single-region-irsacluster.tf— Addednp_capacity_type = "SPOT"and expandednp_instance_typesto multiple types for better SPOT availability:aws-kubernetes-eks-dual-region-createaction — Injected SPOT settings into the generatedterraform-cluster.tfvars:eks-dual-regionGo test helpers — Re-enabled previously commented-out SPOT configuration inTestSetupTerraformandTestTeardownTerraform(had been disabled due to flakiness).Original prompt
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.