Skip to content

Switch EKS tests to SPOT instances#2096

Draft
Copilot wants to merge 2 commits into
mainfrom
copilot/switch-to-spot-instances
Draft

Switch EKS tests to SPOT instances#2096
Copilot wants to merge 2 commits into
mainfrom
copilot/switch-to-spot-instances

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 20, 2026

All EKS test clusters were using ON_DEMAND instances. Switch to SPOT across all test variants to reduce costs, consistent with the approach already used in aws/modules/fixtures/fixtures.default.eks.tfvars.

Changes

  • eks-single-region + eks-single-region-irsa cluster.tf — Added np_capacity_type = "SPOT" and expanded np_instance_types to multiple types for better SPOT availability:

    np_instance_types = ["m6i.xlarge", "m5.xlarge", "m5d.xlarge"]
    np_capacity_type  = "SPOT"
  • aws-kubernetes-eks-dual-region-create action — Injected SPOT settings into the generated terraform-cluster.tfvars:

    np_capacity_type  = "SPOT"
    np_instance_types = ["m6i.xlarge", "m5.xlarge", "m5d.xlarge"]
  • eks-dual-region Go test helpers — Re-enabled previously commented-out SPOT configuration in TestSetupTerraform and TestTeardownTerraform (had been disabled due to flakiness).

Original prompt

This section details on the original issue you should resolve

<issue_title>Switch to SPOT insances for tests</issue_title>
<issue_description>After the merge, switch to SPOT instances in the tests (similar to https://github.com/camunda/camunda-tf-eks-module/blob/main/modules/fixtures/fixtures.default.eks.tfvars)</issue_description>

<agent_instructions>Do it for all tests of the repo</agent_instructions>

Comments on the Issue (you are @copilot in this section)


📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Co-authored-by: leiicamundi <153937047+leiicamundi@users.noreply.github.com>
Copilot AI changed the title [WIP] Switch to SPOT instances for tests Switch EKS tests to SPOT instances Mar 20, 2026
Copilot AI requested a review from leiicamundi March 20, 2026 17:33
@Langleu
Copy link
Copy Markdown
Contributor

Langleu commented Mar 31, 2026

the agent took the instructions very literal 😁.

@leiicamundi
Copy link
Copy Markdown
Contributor

@Langleu the result of this little experience around agents is not successful, it does work only for small things

@Langleu
Copy link
Copy Markdown
Contributor

Langleu commented Mar 31, 2026

I mean it's not that wrong, it just applied it to everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch to SPOT insances for tests

3 participants