Skip to content

test: add minor version upgrade to the upgrade matrix #3377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jessesimpson36
Copy link
Contributor

@jessesimpson36 jessesimpson36 commented Apr 14, 2025

Which problem does the PR fix?

related to
#959
https://github.com/camunda/team-distribution/issues/449
https://github.com/camunda/team-distribution/issues/450

What's in this PR?

Extra jobs that test scenarios like upgrading from latest 8.6 -> 8.7 or latest 8.3 -> 8.4

I separated this patchset by 2 commits:

The first commit is the minimum amount of lines changed needed to get the functionality of testing this extra upgrade-job going from the last minor release to the current chart.

The 2nd commit takes the 5 JQ expressions and converts them to a golang script. IMO this is better because it's more flexible, gives us a lot more structured access to the metadata, and each individual line of code holds less weight and is more easily testable.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@github-actions github-actions bot added area/ci tool/github-actions version/8.7 Camunda applications/cycle version version/8.3 Camunda applications/cycle version version/8.4 Camunda applications/cycle version version/8.5 Camunda applications/cycle version version/8.6 Camunda applications/cycle version labels Apr 14, 2025
@jessesimpson36
Copy link
Contributor Author

The repetitive job logic is now replaced with extra JQ expressions for making the matrix. Nice thing about that is now we don't have to look at dozens of skipped jobs.

@jessesimpson36 jessesimpson36 force-pushed the test-minor-upgrade branch 3 times, most recently from 842669e to 0efe7e2 Compare April 18, 2025 16:43
@jessesimpson36 jessesimpson36 marked this pull request as ready for review April 18, 2025 17:02
@jessesimpson36 jessesimpson36 changed the title test: test minor version upgrade test: add minor version upgrade to the upgrade matrix Apr 18, 2025
@jessesimpson36 jessesimpson36 self-assigned this Apr 18, 2025
@jessesimpson36 jessesimpson36 requested a review from a team April 18, 2025 17:05
@jessesimpson36
Copy link
Contributor Author

Before merging, we will need to remove the test annotation I added into each Chart.yaml. I'm keeping it for now so we can have tests running on each minor version.

@aabouzaid aabouzaid requested review from aabouzaid and removed request for a team April 23, 2025 09:16
Copy link
Member

@aabouzaid aabouzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I write this just to avoid GH pinging me about this PR.
We already discussed changing the approach a bit ... so I will wait for the updated PR.

@jessesimpson36 jessesimpson36 marked this pull request as draft April 25, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci tool/github-actions tool/script version/8.3 Camunda applications/cycle version version/8.4 Camunda applications/cycle version version/8.5 Camunda applications/cycle version version/8.6 Camunda applications/cycle version version/8.7 Camunda applications/cycle version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants