-
Notifications
You must be signed in to change notification settings - Fork 146
test: add minor version upgrade to the upgrade matrix #3377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
6fa6d1b
to
1ec3bfe
Compare
The repetitive job logic is now replaced with extra JQ expressions for making the matrix. Nice thing about that is now we don't have to look at dozens of skipped jobs. |
842669e
to
0efe7e2
Compare
Before merging, we will need to remove the test annotation I added into each Chart.yaml. I'm keeping it for now so we can have tests running on each minor version. |
ebced04
to
10636ba
Compare
ae48ba4
to
133ff88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I write this just to avoid GH pinging me about this PR.
We already discussed changing the approach a bit ... so I will wait for the updated PR.
Which problem does the PR fix?
related to
#959
https://github.com/camunda/team-distribution/issues/449
https://github.com/camunda/team-distribution/issues/450
What's in this PR?
Extra jobs that test scenarios like upgrading from latest 8.6 -> 8.7 or latest 8.3 -> 8.4
I separated this patchset by 2 commits:
The first commit is the minimum amount of lines changed needed to get the functionality of testing this extra upgrade-job going from the last minor release to the current chart.
The 2nd commit takes the 5 JQ expressions and converts them to a golang script. IMO this is better because it's more flexible, gives us a lot more structured access to the metadata, and each individual line of code holds less weight and is more easily testable.
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only
.After opening the PR: