Skip to content

fix: refactor autogenerated secrets #3988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 96 commits into from
Sep 3, 2025
Merged

fix: refactor autogenerated secrets #3988

merged 96 commits into from
Sep 3, 2025

Conversation

@bkenez
Copy link
Member

@bkenez bkenez commented Aug 25, 2025 •
edited
Loading

Which problem does the PR fix?

Closes: #3729

What's in this PR?

Reworking camunda-secrets.yaml after the secrets refactor

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

eamonnmoloney and others added 30 commits July 21, 2025 22:44
@eamonnmoloney
fix: skip 8.8 tests so we can enable the unit tests in the CI again
9807c71
@eamonnmoloney
fix: most tests are asserting and failing the suite rather than the t…
da8816e 
…est. This is part of the change to fix that
@bkenez
feat: add new secret values for firstuser
52191e9
@bkenez
feat: helper function for secret prioritization
4c0851f
@bkenez
fix: update helper
0edffac
@bkenez
fix: test new helper in more places
b5f0855
@bkenez
fix: update deployment
967997d
@bkenez
fix: commit added new secret values
4c38d95
@bkenez
fix: admin secret
6384c42
@bkenez
fix: es secret
6c97bb5
@bkenez
fix: os secrets
20b70e5
@bkenez
Merge branch 'main' of https://github.com/camunda/camunda-platform-helm…
902606a 
… into 1898-enhancement-inconsistent-inputs-for-existingsecret
@distro-ci
chore: chart chores
9ef72fd
@bkenez
feat: add constrait warning about secrets usage
72785b4
@bkenez
Merge branch '1898-enhancement-inconsistent-inputs-for-existingsecret…
30ef1a4 
…' of https://github.com/camunda/camunda-platform-helm into 1898-enhancement-inconsistent-inputs-for-existingsecret
@bkenez
feat: add test for one component that should hit all helper functions
d8c591d
@bkenez
Merge branch 'main' of https://github.com/camunda/camunda-platform-helm…
a79f06e 
… into 1898-enhancement-inconsistent-inputs-for-existingsecret
@bkenez
fix; type checking for constraint
4abc663
@bkenez
fix: extra spapce in helper function failing yamllint on template
ee8777b
@bkenez
fix: correct nesting
0035af6
@bkenez
fix: missing end
3648213
@distro-ci
chore: chart chores
ba456b2
@bkenez
Merge branch 'main' of https://github.com/camunda/camunda-platform-helm…
751475e 
… into 1898-enhancement-inconsistent-inputs-for-existingsecret
@bkenez
Merge branch 'main' of https://github.com/camunda/camunda-platform-helm…
b644a39 
… into 1898-enhancement-inconsistent-inputs-for-existingsecret
@distro-ci
chore: chart chores
43e1424
@bkenez
fix: first round of suggested fixes
4ac0c26
@bkenez
Merge branch '1898-enhancement-inconsistent-inputs-for-existingsecret…
a2e7483 
…' of https://github.com/camunda/camunda-platform-helm into 1898-enhancement-inconsistent-inputs-for-existingsecret
@distro-ci
chore: chart chores
8979326
@bkenez
Merge branch 'main' of https://github.com/camunda/camunda-platform-helm…
903a698 
… into 1898-enhancement-inconsistent-inputs-for-existingsecret
@bkenez
Merge branch '1898-enhancement-inconsistent-inputs-for-existingsecret…
455be92 
…' of https://github.com/camunda/camunda-platform-helm into 1898-enhancement-inconsistent-inputs-for-existingsecret
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-3988-intg-8-8-gke-eske August 29, 2025 08:20 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-3988-intg-8-8-gke-eske-upgrade August 29, 2025 08:20 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-3988-intg-8-8-gke-eske September 1, 2025 09:02 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-3988-intg-8-8-gke-eske-upgrade September 1, 2025 09:02 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-3988-intg-8-8-gke-eske September 3, 2025 09:56 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-3988-intg-8-8-gke-eske-upgrade September 3, 2025 09:56 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-3988-intg-8-8-gke-eske-upgrade September 3, 2025 10:18 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-3988-intg-8-8-gke-eske-upgrade September 3, 2025 10:41 In progress
@hisImminence hisImminence requested review from jessesimpson36 and removed request for hamza-m-masood September 3, 2025 12:59
@bkenez bkenez changed the title fix: fix autogen secrets fix: refactor autogenerated secrets Sep 3, 2025
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-3988-intg-8-8-gke-eske September 3, 2025 13:49 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-3988-intg-8-8-gke-eske-upgrade September 3, 2025 13:49 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-3988-intg-8-8-gke-eske-upgrade September 3, 2025 18:00 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-3988-intg-8-8-gke-eske September 3, 2025 18:00 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-3988-intg-8-8-gke-eske-upgrade September 3, 2025 18:03 In progress
@bkenez bkenez merged commit 5684195 into main Sep 3, 2025
21 of 22 checks passed
@bkenez bkenez deleted the 3729-fix-autogen-secrets branch September 3, 2025 18:21
@distro-ci distro-ci bot mentioned this pull request Sep 2, 2025
Merged
@github-actions github-actions bot added the version:13.0.0-alpha8 Issues and PRs related to chart version 13.0.0-alpha8 label Sep 12, 2025
@bkenez bkenez self-assigned this Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jessesimpson36 jessesimpson36 jessesimpson36 approved these changes

Assignees

@bkenez bkenez

Labels

component/connectors component/console component/identity component/optimize component/orchestration component/web-modeler version/8.8 Camunda applications/cycle version version:13.0.0-alpha8 Issues and PRs related to chart version 13.0.0-alpha8

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ISSUE] global.secrets.autoGenerated does not work for basic auth in 8.8.

4 participants

@bkenez @jessesimpson36 @eamonnmoloney