Skip to content

fix: append -certs to the namespace to match infra changes #4055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2025
Merged

fix: append -certs to the namespace to match infra changes #4055

merged 1 commit into from
Sep 1, 2025

Conversation

@eamonnmoloney
Copy link
Contributor

@eamonnmoloney eamonnmoloney commented Sep 1, 2025 •
edited
Loading

Which problem does the PR fix?

Infra renamed the namespace with the tls in it. This change reflects that for EKS

What's in this PR?

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to eks--intg-8-8-eks-eske September 1, 2025 13:19 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to eks--intg-8-8-eks-eske September 1, 2025 13:26 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to eks--intg-8-8-eks-eske September 1, 2025 13:27 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to eks--intg-8-8-eks-eske September 1, 2025 13:33 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to eks--intg-8-8-eks-eske September 1, 2025 13:39 Destroyed
@eamonnmoloney eamonnmoloney marked this pull request as ready for review September 1, 2025 13:41
@eamonnmoloney eamonnmoloney requested a review from a team as a code owner September 1, 2025 13:41
@eamonnmoloney eamonnmoloney requested a review from bkenez September 1, 2025 13:41
@eamonnmoloney
Copy link
Contributor Author

eamonnmoloney commented Sep 1, 2025

Good build here https://github.com/camunda/camunda-platform-helm/actions/runs/17379305730

bkenez
bkenez approved these changes Sep 1, 2025
View reviewed changes
Copy link
Member

@bkenez bkenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear change, approved

@eamonnmoloney eamonnmoloney merged commit 5188e87 into main Sep 1, 2025
14 of 15 checks passed
@eamonnmoloney eamonnmoloney deleted the fix-eks-cert-deploy branch September 1, 2025 13:47
@jessesimpson36 jessesimpson36 mentioned this pull request Sep 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkenez bkenez bkenez approved these changes

Assignees

No one assigned

Labels

area/ci tool/github-actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eamonnmoloney @bkenez