Skip to content

Conversation

@hamza-m-masood
Copy link
Contributor

@hamza-m-masood hamza-m-masood commented Sep 1, 2025

Which problem does the PR fix?

related: https://github.com/camunda/team-distribution/issues/415

Decisions I have made for the separate improter deployment:

  • The importer is disabled by default
  • The importer does not have a kubernetes service
  • I added a section in the values.yaml for the importer with values I find relevant for the customer to modify the import deployment
  • The importer deployment is using the same service account as the orchestration cluster
  • Removed all ports
  • Removed priorityClassName
  • Removed sidecars
  • The security context of the orchestration cluster is the same as the importer deployment
  • The node selector and affinity of the orchestration cluster is the same as the importer deployment

The separate importer deployment can simply be tested by deploying the 8.8 helm chart with either keycloak or basic auth enabled and setting the following value to true in the values.yaml:

orchestration
  importer
    enabled: true

What's in this PR?

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@github-actions github-actions bot added version/8.8 Camunda applications/cycle version component/orchestration labels Sep 1, 2025
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-4058-intg-8-8-gke-eske September 1, 2025 21:00 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-4058-intg-8-8-gke-eske-upgrade September 1, 2025 21:00 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-4058-intg-8-8-gke-eske-upgrade September 1, 2025 21:03 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-4058-intg-8-8-gke-eske September 1, 2025 21:03 Destroyed
@hamza-m-masood hamza-m-masood self-assigned this Sep 2, 2025
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-4058-intg-8-8-gke-eske September 3, 2025 11:16 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-4058-intg-8-8-gke-eske-upgrade September 3, 2025 11:16 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-4058-intg-8-8-gke-eske-upgrade September 3, 2025 11:18 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-4058-intg-8-8-gke-eske September 3, 2025 11:18 Destroyed
@hamza-m-masood hamza-m-masood marked this pull request as ready for review September 3, 2025 11:28
@hamza-m-masood hamza-m-masood requested a review from a team as a code owner September 3, 2025 11:28
@hamza-m-masood hamza-m-masood requested review from aabouzaid and bkenez and removed request for bkenez September 3, 2025 11:28
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-4058-intg-8-8-gke-eske-upgrade September 3, 2025 13:48 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-4058-intg-8-8-gke-eske September 3, 2025 13:48 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-4058-intg-8-8-gke-eske September 3, 2025 16:35 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-4058-intg-8-8-gke-eske-upgrade September 3, 2025 16:35 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-4058-intg-8-8-gke-eske-upgrade September 3, 2025 16:54 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-4058-intg-8-8-gke-eske September 3, 2025 16:54 Destroyed
## @extra orchestration.importer configuration for the external tasklist and operate importer deployment for the orchestration cluster
importer:
## @param orchestration.importer.enabled if true, the orchestration cluster deployment and its related resources are deployed via a helm release
enabled: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any case where we need to enable one of the importers but not the other 🤔 (Operate only or Tasklist only)

What happens if a user deploys 8.7 with one of the apps only (Operate or Tasklist)? Will the importer handle this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any case where we need to enable one of the importers but not the other 🤔 (Operate only or Tasklist only)

To be honest, I don't have enough customer setup knowledge to answer that question. @theburi what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if a user deploys 8.7 with one of the apps only (Operate or Tasklist)? Will the importer handle this?

It would not matter too much what they did on 8.7 I think. What we really want to test here is if the operate/tasklist importer deployment works when either the operate or tasklist profile is enabled in the 8.8 orchestration cluster.

I can test this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the steps I did:

  • Fresh install of 8.8 SNAPSHOT making sure the the orchestration cluster did not have the tasklist profile
  • deployed the external importer deployment with the following profiles: tasklist,operate,consolidated-auth
  • Once all pods were healthy I deployed 2 models to the orchestration cluster

I can see the 2 models on the operate UI.

@hamza-m-masood
Copy link
Contributor Author

@jessesimpson36 thanks for the approval. After pairing with Ahmed, we decided to remove the podLabels,podAnnotations,dnsConfig,dnsPolicy from the importer in the values.yaml

@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-4058-intg-8-8-gke-eske September 5, 2025 16:43 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-4058-intg-8-8-gke-eske-upgrade September 5, 2025 16:43 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-4058-intg-8-8-gke-eske-upgrade September 5, 2025 16:46 In progress
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-4058-intg-8-8-gke-eske September 5, 2025 16:46 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot requested a deployment to gke-4058-intg-8-8-gke-eske-upgrade September 5, 2025 17:12 In progress
@hamza-m-masood hamza-m-masood merged commit b9d8673 into main Sep 5, 2025
16 of 17 checks passed
@hamza-m-masood hamza-m-masood deleted the importer-deployment branch September 5, 2025 17:14
@github-actions github-actions bot added the version:13.0.0-alpha8 Issues and PRs related to chart version 13.0.0-alpha8 label Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/orchestration version/8.8 Camunda applications/cycle version version:13.0.0-alpha8 Issues and PRs related to chart version 13.0.0-alpha8

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants