-
Notifications
You must be signed in to change notification settings - Fork 148
feat: add tasklist and operate importer as a separate deployment #4058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
charts/camunda-platform-8.8/templates/orchestration/importer-deployment.yaml
Show resolved
Hide resolved
c4e8b46 to
c219ec0
Compare
c219ec0 to
4446685
Compare
| ## @extra orchestration.importer configuration for the external tasklist and operate importer deployment for the orchestration cluster | ||
| importer: | ||
| ## @param orchestration.importer.enabled if true, the orchestration cluster deployment and its related resources are deployed via a helm release | ||
| enabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any case where we need to enable one of the importers but not the other 🤔 (Operate only or Tasklist only)
What happens if a user deploys 8.7 with one of the apps only (Operate or Tasklist)? Will the importer handle this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any case where we need to enable one of the importers but not the other 🤔 (Operate only or Tasklist only)
To be honest, I don't have enough customer setup knowledge to answer that question. @theburi what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if a user deploys 8.7 with one of the apps only (Operate or Tasklist)? Will the importer handle this?
It would not matter too much what they did on 8.7 I think. What we really want to test here is if the operate/tasklist importer deployment works when either the operate or tasklist profile is enabled in the 8.8 orchestration cluster.
I can test this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are the steps I did:
- Fresh install of 8.8 SNAPSHOT making sure the the orchestration cluster did not have the
tasklistprofile - deployed the external importer deployment with the following profiles:
tasklist,operate,consolidated-auth - Once all pods were healthy I deployed 2 models to the orchestration cluster
I can see the 2 models on the operate UI.
f3aeec0 to
df251f7
Compare
df251f7 to
9efb83c
Compare
|
@jessesimpson36 thanks for the approval. After pairing with Ahmed, we decided to remove the podLabels,podAnnotations,dnsConfig,dnsPolicy from the importer in the values.yaml |
Which problem does the PR fix?
related: https://github.com/camunda/team-distribution/issues/415
Decisions I have made for the separate improter deployment:
The separate importer deployment can simply be tested by deploying the 8.8 helm chart with either keycloak or basic auth enabled and setting the following value to true in the values.yaml:
What's in this PR?
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only.After opening the PR: